Unable to use Callable with connect in HTTPRequest in GodotJS

[G159w]

Hi there,

I'm working with GodotJS (Godot Editor 0.9.8 from the prebuild list) using the HTTPRequest node, and I attempted to use a Callable with the connect function like this:

httpRequest.connect(
  'request_completed',
  new Callable(this, this.download_completed.name).bind(entry),
);
httpRequest.request(url);

However, I have this type error when I use the .bind() function:

Argument of type 'AnyCallable' is not assignable to parameter of type 'Callable'.
  Type 'AnyCallable' is missing the following properties from type 'Callable': callv, bindv, unbind, call, and 4 more.ts(2345)

The doc says:

_Returns a copy of this [Callable] with one or more arguments bound. When called, the bound arguments are passed after the arguments supplied by [method call]. See also [method unbind].

Do you ave an idea on how can I fix this issue ?

Thank you in advance.

[ialex32x]

I tried similar codes in the latest version without this error reported. It should has been fixed in the commits after the exe was built by Github Actions. I'll generate another build again to check whether it's fixed.

const req = new HTTPRequest();
this.add_child(req);
// 1:
// req.request_completed.connect(new Callable(this, this.dummy_call.name).bind(123));
// 2:
// req.connect("request_completed", new Callable(this, this.dummy_call.name).bind(123));
// 3:
req.request_completed.connect(Callable.create(this, this.dummy_call).bind(123));
req.request(url);

[G159w]

After update the godot editor to v0.9.9 and regenerate typing, tsconfig and node_modules

Without bind it works

// Works

download_file(): void {
  const req = new HTTPRequest();
  this.add_child(req);
  req.request_completed.connect(Callable.create(this, this.download_completed));
  req.request(url);
}

download_completed(
   _result: number,
  responseCode: number,
  _headers: string[] | PackedStringArray,
  body: PackedByteArray | number[] | ArrayBuffer,
): void { }

But if I add bind:

// Ts problem on .bind

download_file(): void {
  const req = new HTTPRequest();
  this.add_child(req);
  req.request_completed.connect(Callable.create(this, this.download_completed).bind(123));
  req.request(url);
}

download_completed(
   _result: number,
  responseCode: number,
  _headers: string[] | PackedStringArray,
  body: PackedByteArray | number[] | ArrayBuffer,
  entry: number
): void { }

then, I have this error :

Property 'bind' does not exist on type 'Callable5<number, number, string[] | PackedStringArray, PackedByteArray | number[] | ArrayBuffer, number, void>'.ts(2339)

[ialex32x]

It could be ignored temporarily (tsc will emit the code even with this error ),
the binded parameter you pass will be transfered as the last argument entry for download_completed .

The generated JS code should work with expected results.

[ialex32x]

I'll improve the d.ts later.

[G159w]

I confirm that with the last release it works 👍

[ialex32x]

It works in godot_editor_v0.9.9. I'll improve the GodotJS-Build workflow later (automatically build for major platform+arch+JS Engines for every release tag).

By the way, Callable.create is more recommended since it's strongly typed.
Thanks for trying GodotJS, please feel free to report issues or any discussions.