Separate Node editor dock #101787
Separate Node editor dock #101787
Conversation
Break-Ben
force-pushed
the
signals-and-groups-docks
branch
2 times, most recently
from
0c4ecf0 to
a690020
Compare
There was a problem hiding this comment.
As is, the current PR breaks compatibility with feature profiles because of the removal of FEATURE_NODE_DOCK and the two new features added in the middle. The FEATURE_NODE_DOCK constant should at least be marked as deprecated. But it would also no longer do anything, which is likely not desired...
Separated the Node editor dock into a Signals dock and a Groups dock.
Break-Ben
force-pushed
the
signals-and-groups-docks
branch
from
a690020 to
aea7e83
Compare
|
I've updated it so that the While I believe that it should be compatible now, it's definitely not ideal. To be honest, I don't have enough knowledge about feature profiles to propose a better solution to this (for example I assumed the order of the enum didn't matter since the integer values don't seem to be used other than in memory, but I guess that's not true), but if anyone else knows a better way this could be done, that would be great. |
Closes godotengine/godot-proposals#11590
Alternative PR: #101584
Also related to godotengine/godot-proposals#9052 and godotengine/godot-proposals#9448
Separated the Node editor dock into a Signals editor dock and a Groups editor dock (justification in the linked proposal).
Before:
After:
Note that I had to resize the default width of the right panel from 270 pixels to 320 pixels to allow it to fit, but I didn't touch the width of the left panel which remains at 270 pixels. I personally don't think its an issue that they no longer are the same width as it isn't very noticeable (and realistically most users resize these panels anyway), but it is worth noting.
Thanks :)
This PR is currently fully functional but won't be marked as ready until a solution is determined for feature profiles. Currently, the node dock is marked as deprecated but still shown in the list, with the signals and groups docks added to the bottom (as shown here), but a cleaner solution that doesn't break compatibility would be ideal.