Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially refunded transactions are fully removed from the "Net Sales" amount #2861

Open
brianhogg opened this issue Jan 24, 2025 · 1 comment
Assignees
Labels
Severity: Normal Status: Has PR This issue has an open pull request

Comments

@brianhogg
Copy link
Contributor

Reproduction Steps

  1. On a store with a subscription Order placed in the past that has been placed or renewed this month, go to LifterLMS > Reporting, "Sales" tab
  2. Click Toggle Filters and select the Membership or Course for the Order
  3. Choose a date range that covers one or more transactions for the Order and click Apply Filters
  4. In a separate tab, edit the Order and partially refund a transaction
  5. In the tab with Reporting, click Apply Filters again or refresh the page

Expected Behavior

"Net Sales" is reduced by the amount of the partial refund

Actual Behavior

"Net Sales" is reduced by the full amount of the transaction

Tech Notes

We should include transactions with both llms-txn-succeeded and llms-txn-refunded since a partially refunded transaction currently has the status set to llms-txn-refunded

@ideadude ideadude moved this to Awaiting Triage in Development Jan 24, 2025
@brianhogg
Copy link
Contributor Author

Related to #2860

@ideadude ideadude self-assigned this Jan 24, 2025
@brianhogg brianhogg assigned brianhogg and unassigned ideadude Jan 24, 2025
@brianhogg brianhogg added the Status: Has PR This issue has an open pull request label Jan 24, 2025
@brianhogg brianhogg moved this from Awaiting Triage to Awaiting Review in Development Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Severity: Normal Status: Has PR This issue has an open pull request
Projects
Status: Awaiting Review
Development

No branches or pull requests

2 participants