Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord plugin update notifications occasionally feature the wrong author #71

Open
philpax opened this issue Jan 3, 2025 · 0 comments

Comments

@philpax
Copy link
Contributor

philpax commented Jan 3, 2025

This notification, corresponding to a plugin update by wompscode (#5294), was instead attributed to Populo, who submitted their own update (#5297) which was correctly attributed.

Looking at the code for XLWebServices, it appears that the author information is drawn from the PR number specified in the staged builds:
https://github.com/goatcorp/XLWebServices/blob/1f198735c47b361d477943a1a5c28e2526bc396a/XLWebServices/Controllers/PlogonController.cs#L244
https://github.com/goatcorp/XLWebServices/blob/1f198735c47b361d477943a1a5c28e2526bc396a/XLWebServices/Controllers/PlogonController.cs#L290

And that PR number appears to come from Plogon:

PrNumber = committingPrNum.Value,

My hypothesis is that these builds are being staged with the number of the last PR to trigger a Plogon commit, which is not necessarily the same as each of the PRs that would be rolled into that commit - which would explain why the earlier update has the authorship of the later update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant