Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Settings option to always create a new Terminal instance when outputTo=terminal #126

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

yoiang
Copy link
Contributor

@yoiang yoiang commented Mar 5, 2024

Hello y'all!
This PR addresses the most basic part of #124 and #125 by adding a Settings option to have "outputTo": "terminal" always create a new Terminal instance. Since this requires a bit more work on the user's part to keep from creating a mess of Terminal windows this behavior defaults to false, ie: turned off.

I will attempt a second PR that will add the Settings option to create Terminal windows that end their process once the Task has finished (and prompt with the Press any key to close VSCode uses)

@pd93 pd93 merged commit beed319 into go-task:main Apr 5, 2024
1 of 3 checks passed
@pd93
Copy link
Member

pd93 commented Apr 5, 2024

@yoiang thanks for the contribution! I've made a couple of changes in 5c14e5c. The setting you've added will now be nested under some dedicated terminal settings:

{
    ...
    "task": {
        "terminal": {
            "per": "task", // default is "window"
        }
    }
    ...
}

Very open to feedback.

@yoiang
Copy link
Contributor Author

yoiang commented Apr 6, 2024

Awesome! 🤩

@beholdr
Copy link

beholdr commented May 28, 2024

When this will be released in VSCode marketplace?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants