Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slippy.PixelsToNative ignores pixels argument #128

Open
jchamberlain opened this issue Oct 30, 2023 · 0 comments
Open

slippy.PixelsToNative ignores pixels argument #128

jchamberlain opened this issue Oct 30, 2023 · 0 comments

Comments

@jchamberlain
Copy link

Problem

PixelsToNative should convert the accepted pixels number into projected/native units. Instead, it doesn't use the variable at all and merely returns the ratio of native to projected.

Solution

Refactor PixelsToNative to either:

  1. Convert pixels, or
  2. Not accept pixels (in which case, the function should be renamed to something like PixelsToNativeRatio).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant