Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to view performance data in Sentry #223

Open
zKoz210 opened this issue Aug 9, 2024 · 3 comments
Open

Add the ability to view performance data in Sentry #223

zKoz210 opened this issue Aug 9, 2024 · 3 comments
Labels
contributions welcome Looking for contributors feature request Request for new feature implementation

Comments

@zKoz210
Copy link

zKoz210 commented Aug 9, 2024

Proposal

Discussion:

There is a real lack of speed monitoring, such as Sentry.

Monitoring http speed, monitoring the speed of queries in the database, monitoring queries in the Redis storage (if there is such a thing in the future)

@System-Glitch System-Glitch added feature request Request for new feature implementation contributions welcome Looking for contributors labels Aug 11, 2024
@System-Glitch
Copy link
Member

System-Glitch commented Aug 11, 2024

There is a plugin for Datadog tracing support: dd-trace-goyave. I think it's definitely possible to do something similar for Sentry.

@zKoz210
Copy link
Author

zKoz210 commented Aug 13, 2024

https://github.com/getsentry/sentry-go
https://docs.sentry.io/platforms/go/guides/http/configuration/options/

The official sentry package supports net/http. Is there some least costly way we can integrate this into your structure?

Thank you for answering all questions so quickly! I tried to write a small application with your framework and it really makes life easier in basic things.

@System-Glitch
Copy link
Member

I had a look at their implementation. I think we can create an adapter for Goyave in a separate repository. It would require some work to make it very clean though. We need:

  • A chained writer (replicating their "wrap writer")
  • A middleware (to replace the writer and replicate their middleware behavior)
  • A status handler to handle the panic recovery the Goyave way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions welcome Looking for contributors feature request Request for new feature implementation
Projects
None yet
Development

No branches or pull requests

2 participants