Fix for Maven Package Naming Convention Handling #33678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
github-actions
bot
added
modifies/api
wxiaoguang
reviewed
Feb 21, 2025
wxiaoguang
force-pushed
the
fix-maven-bug
branch
from
f6a8384 to
189c0ed
Compare
pull-request-size
bot
added
size/S
wxiaoguang
force-pushed
the
fix-maven-bug
branch
from
189c0ed to
2f5d355
Compare
pull-request-size
bot
added
size/L
pull-request-size
bot
added
size/S
pull-request-size
bot
added
size/M
|
And added some tests in 795b3f5, it should be right now. Without the fix, the tests fail. |
wxiaoguang
approved these changes
Feb 21, 2025
GiteaBot
added
lgtm/need 1
wxiaoguang
added
type/bug
backport/v1.23
lunny
approved these changes
Feb 21, 2025
GiteaBot
added
lgtm/done
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Feb 21, 2025
Make legacy package names could be listed and add tests --------- Co-authored-by: [email protected] <[email protected]> Co-authored-by: wxiaoguang <[email protected]>
wxiaoguang
added a commit
that referenced
this pull request
Feb 21, 2025
Backport #33678 by dianaStr7 Co-authored-by: Diana <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: wxiaoguang <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 24, 2025
* giteaofficial/main: Fix git empty check and HEAD request (go-gitea#33690) Fix some user name usages (go-gitea#33689) Try to fix ACME path when renew (go-gitea#33668) [skip ci] Updated translations via Crowdin Improve Open-with URL encoding (go-gitea#33666) Fix for Maven Package Naming Convention Handling (go-gitea#33678) Improve swagger generation (go-gitea#33664) Deleting repository should unlink all related packages (go-gitea#33653)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses the bug reported in #33672 related to the handling of Maven packages with older naming conventions. The
getVersionByPackageNamemethod in thepackage_versionhas been updated to throw an exception ErrNotExist when no packages are found. This error already was expected for the call back mechanism for maven packages for legacy name handling.Changes Made
Make legacy package names could be listed and add tests
Related Ticket