Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mCaptcha bug #33659

Merged
merged 3 commits into from
Feb 20, 2025
Merged

Fix mCaptcha bug #33659

merged 3 commits into from
Feb 20, 2025

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Feb 20, 2025 •
edited
Loading

Fix #33658

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 20, 2025
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 20, 2025
@wxiaoguang wxiaoguang mentioned this pull request Feb 20, 2025
Closed
@wxiaoguang wxiaoguang added backport/v1.23 This PR should be backported to Gitea 1.23 and removed modifies/frontend labels Feb 20, 2025
@wxiaoguang
Copy link
Contributor Author

image

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 20, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 20, 2025
@wxiaoguang wxiaoguang merged commit cd225d7 into go-gitea:main Feb 20, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Feb 20, 2025
@wxiaoguang wxiaoguang deleted the fix-mcaptcha branch February 20, 2025 14:53
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Feb 20, 2025
@wxiaoguang @GiteaBot
Fix mCaptcha bug (go-gitea#33659)
84049f0 
Fix go-gitea#33658
@GiteaBot GiteaBot mentioned this pull request Feb 20, 2025
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Feb 20, 2025
wxiaoguang added a commit that referenced this pull request Feb 20, 2025
@GiteaBot @wxiaoguang
Fix mCaptcha bug (#33659) (#33661)
9da6d4e 
Backport #33659 by wxiaoguang

Fix #33658

Co-authored-by: wxiaoguang <[email protected]>
@silverwind
Copy link
Member

This glue package is definitely very low quality, I've excluded it from updates because something broke the last time I tried:

gitea/updates.config.js

Line 3 in a25081f

'@mcaptcha/vanilla-glue', // breaking changes in rc versions need to be handled

Also, it seems to still not have reached v1.0.0, despite the authors promising to stabilize:

https://github.com/mCaptcha/glue

If it's too much of a problem, I would even consider dropping the mCaptcha support until they can provide a quality module.

@wxiaoguang
Copy link
Contributor Author

If it's too much of a problem, I would even consider dropping the mCaptcha support until they can provide a quality module.

Yep, I also agree if there is no user using it .... but since there are still users using it, maybe we could just keep it as-is. Anyway, just a few lines.

zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 21, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
681ec25 
* giteaofficial/main:
  Fix omitempty bug (go-gitea#33663)
  Upgrade golangci-lint to v1.64.5 (go-gitea#33654)
  Fix mCaptcha bug (go-gitea#33659)
  Update Go dependencies (skip blevesearch, meilisearch) (go-gitea#33655)
  Use test context in tests and new loop system in benchmarks (go-gitea#33648)
  Add missed changelogs (go-gitea#33649)
  [skip ci] Updated translations via Crowdin
  git graph: don't show detached commits (go-gitea#33645)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvh delvh delvh approved these changes

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

mcaptcha usage creates javascript error
5 participants
@wxiaoguang @silverwind @delvh @hiifong @GiteaBot