Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Legend of the chart #574

Open
josojo opened this issue May 19, 2021 · 9 comments · May be fixed by #763
Open

[UI] Legend of the chart #574

josojo opened this issue May 19, 2021 · 9 comments · May be fixed by #763
Assignees

Comments

@josojo
Copy link
Contributor

josojo commented May 19, 2021

Currently the legend looks quite profan:
image.png

Can we please get a new design proposal + later on implementataion

@josojo josojo changed the title Legend of the chart [UI] Legend of the chart May 31, 2021
@alongoni alongoni self-assigned this Jun 1, 2021
@alongoni
Copy link
Contributor

alongoni commented Jun 9, 2021

image
First and simple approach: We can add a label for each legend.

Regarding #468 maybe we can add the current price in the legends. Also I can try to present this in the charts, but I'm not sure is the simple way to implement it.

Any suggestion? @josojo @cmagan @ramirotw

@josojo
Copy link
Contributor Author

josojo commented Jun 9, 2021

Regarding #468 maybe we can add the current price in the legends.

yeah, if we find a good way to implement it, that would be great. Though in the past this chart library has not proven itself to be the most flexible and performant one.

For me, representing the price has no high prior, as it is visible within the auction dettails

@ramirotw
Copy link
Contributor

ramirotw commented Jun 9, 2021

Another option could be putting the current price value in the Current Price legend tooltip, that would probably be easier. I see value in having the chart's current price value as it can change depending on the Place Order's form.

@alongoni
Copy link
Contributor

alongoni commented Jun 10, 2021

image
I've added two more options:

  • adding current price in a tooltip
  • adding the current price over the graph.

cc @josojo @ramirotw

@josojo
Copy link
Contributor Author

josojo commented Jun 11, 2021

The second option looks way more fancy and better. Though, I don't know how long it would take to implement. @maria-vslvn what do you think? Is it implementable?
The first option is very easy to implement...

@cmalfesi
Copy link

@maria-vslvn
Please, check and let us know your thoughts to implement this. And estimate.

@cmagan
Copy link
Contributor

cmagan commented Jun 14, 2021

I like the left one with the price on top of the white dashed line!

@elena-zh
Copy link

Hey @maria-vslvn ,
could you please also take a look at the #723 issue while implementing this task?
Thanks

@ramirotw
Copy link
Contributor

@maria-vslvn lets implement the current price in the tooltip as adding the overlay to the graph could be complicated

@maria-vslvn maria-vslvn linked a pull request Jul 6, 2021 that will close this issue
@maria-vslvn maria-vslvn linked a pull request Jul 6, 2021 that will close this issue
maria-vslvn pushed a commit that referenced this issue Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants