tests/tags.t output is nondeterministic

[riastradh]

I hit this failure once while running tests for #342, out of probably a dozen or two runs of the test suite:

--- tests/tags.t
+++ tests/tags.t.err
@@ -409,9 +409,9 @@
   remote: adding changesets
   remote: adding manifests
   remote: adding file changes
+  To hg::/tmp/riastradh/cramtests-wyn6pbnq/tags.t/repo
+   * [new branch]      tags -> branches/default/tip
   remote: added 0 changesets with 0 changes to 1 files
-  To hg::(.*)/tags.t/repo (re)
-   * [new branch]      tags -> branches/default/tip
 
   $ set_date
   $ git -C repo-git3 cinnabar tag -m "remove tag d" -d TAG_D

I only saw it once -- have not reproduced it.

Does part of the push finish asynchronously in the background, rather than synchronously before the git output about the results of the push?

[glandium]

This comes from this output being handled in a separate thread here: https://github.com/glandium/git-cinnabar/blob/master/src/hg_connect_stdio.rs#L258-L268 and there is no synchronization between that and sending output to git in https://github.com/glandium/git-cinnabar/blob/master/src/main.rs#L4948 or https://github.com/glandium/git-cinnabar/blob/master/src/main.rs#L4495. The only way to fix this would be to assume that git is not going to do anything with the remote after sending its import or push commands.

[glandium]

I actually found a convoluted way to make it work. Fixed in c55ffbc.