Skip to content
This repository has been archived by the owner on Dec 2, 2022. It is now read-only.

OpenGraph Markup Description #840

Open
vvhof opened this issue Jul 19, 2017 · 6 comments
Open

OpenGraph Markup Description #840

vvhof opened this issue Jul 19, 2017 · 6 comments
Labels
Information required

Comments

@vvhof
Copy link

vvhof commented Jul 19, 2017

Summary

Moodle is not generating certain information that would allow other application to generate a website preview.

If a website is shared via its URL on Slack, Skype, Whatsapp or Facebook, said clients derive a preview representation based upon information provided in OpenGraph Markup.

More Information: OpenGraph Markup

Details

Steps to Reproduce

  1. Go to Facebook Debug Tool
  2. Insert Moodle instance URL

...or share in Slack, Skype, etc.

Expected Result

A preview representation of the Moodle website including a title, a short description and an image.

Actual Result

No preview is generated.

Environment

Linux with 4.4.0-83-generic
skypeforlinux 5.3.0.1
Slack 2.6.3 64-bit Beta Channel

Warnings That Should Be Fixed
The 'og:url' property should be explicitly provided, even if a value can be inferred from other tags.
The 'og:title' property should be explicitly provided, even if a value can be inferred from other tags.
The 'og:description' property should be explicitly provided, even if a value can be inferred from other tags.
The 'og:image' property should be explicitly provided, even if a value can be inferred from other tags.
from Facebook Debug Tool
@gjb2048
Copy link
Owner

gjb2048 commented Jul 19, 2017

Ok, interesting, why should I spend my time on this?

@gjb2048
Copy link
Owner

gjb2048 commented Jul 19, 2017

And looking at http://ogp.me/ - why should this not be a core rather than an Essential thing?

@vvhof
Copy link
Author

vvhof commented Jul 20, 2017 

<html prefix="og: http://ogp.me/ns#">
<head>
<title>The Rock (1996)</title>
<meta property="og:title" content="The Rock" />
<meta property="og:type" content="video.movie" />
<meta property="og:url" content="http://www.imdb.com/title/tt0117500/" />
<meta property="og:image" content="http://ia.media-imdb.com/images/rock.jpg" />
</head>
</html>

As the change required appears as meta information in the page title, i had assumed it to be a theme 'thing'.
If the head is already constructed by the core, i suppose it would indeed be a core 'thing'

@gjb2048
Copy link
Owner

gjb2048 commented Jul 20, 2017

Hi Vincent,

That's not what I meant. I'm talking about the 'why' and 'where' not the how. If it should be done then the 'where' should probably be core so that all Moodle installations have it without every contributed theme having to update.

So please kindly state 'why' this should be done.

Kind regards,

Gareth

@gjb2048
Copy link
Owner

gjb2048 commented Oct 29, 2017

Hi Vincent,

Please provide further information as requested or I'll close this.

Kind regards,

Gareth

@vvhof
Copy link
Author

vvhof commented Oct 30, 2017 •
edited
Loading

Hello Gareth,

  • Why: Sharing a moodle link in certain applications is not as information rich, as it could be. A user might already see in the other application, what kind of course a link will take him to.

  • (Regarding 'where': As I am not a moodle contributor, i do not have the capability to make assumptions about where a solution would fit into the projects. My initial unitiated gut feeling was, that this is just another type of content representation and thus might make sense to be placed in a theme that deals precisely with that: representation. I apologize if I brought the issue to the wrong address)

If you agree with the 'why', I'd kindly ask for your opinion on the 'where'. Otherwise consider this closed.

Best regards,
Vincent

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Information required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gjb2048 @vvhof