Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Graph Responsive #100

Open
titojankowski opened this issue Nov 17, 2017 · 7 comments
Open

Make Graph Responsive #100

titojankowski opened this issue Nov 17, 2017 · 7 comments
Assignees
Milestone

Comments

@titojankowski
Copy link
Contributor

Before window resized: Mouse hovered over June 02, 1996
screen shot 2017-11-16 at 4 05 04 pm

After window resized smaller: Mouse hovered roughly over June 02, 1996, but reads to the left 350, November 13, 1988:
screenshot 2017-11-16 16 06 48

After window resized bigger: Mouse hovered roughly over June 02, 1996, but reads to the right, 368, December 09, 1999:
screen shot 2017-11-16 at 4 07 33 pm

@grady-lad
Copy link
Contributor

Hey @titojankowski This issue is to do with the responsiveness of the graph, maybe we can rename the issue make graph responsive And close issues #88 and #95 ???

@grady-lad grady-lad self-assigned this Nov 17, 2017
@titojankowski titojankowski changed the title Graph label is off after window is resized Make Graph Responsive Nov 17, 2017
@titojankowski
Copy link
Contributor Author

Great idea!! Will do.

@titojankowski
Copy link
Contributor Author

Merging here:

@grady-lad
Copy link
Contributor

@titojankowski merged some work from #102 could you check it out again ?

@titojankowski
Copy link
Contributor Author

Label position after resize - works!
Spacing on axis label - no more overlap!

Round dot is still oblong tho after resize.
92c4c6ce-6534-4aa3-ad6d-54e81a0a5f5c

@grady-lad

@grady-lad
Copy link
Contributor

The round dot may have to be a different component. I.E A Path component which is styled as a circle via css, this would make it possible to show different shapes on different screen sizes

@titojankowski
Copy link
Contributor Author

Is there a way to make the width and length the same...or just define a radius? That way at least it’s
not oblong. :0

@decentral1se decentral1se added this to the P1: MUST milestone Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants