apps/backend/src/services/auth/auth.service.ts (2)

37-40: Assert consistent user feedback when signup is disabled.

When throwing the error 'Signup is disabled' here, ensure that the frontend properly handles and displays it. Consider returning a status code for a disabled signup scenario that is distinct from other error codes, making it easier for clients to handle this specific condition.

---

139-142: Avoid duplicating signup-disabled check logic.

These lines replicate the logic introduced in the routeAuth method. To keep the code DRY, consider abstracting the signup-disabled check into a shared helper function or a guard. That would ensure consistency & easier maintenance.

- if (process.env.DISABLE_SIGNUP === 'true') {
-   throw new Error('Signup is disabled');
- }
+ this.ensureSignupEnabled();

... // Then define a small helper function:
private ensureSignupEnabled() {
  if (process.env.DISABLE_SIGNUP === 'true') {
    throw new Error('Signup is disabled');
  }
}

.env.example (1)

10-10: Provide environment variable usage instructions.

This new environment variable is critical to controlling user registration. Consider adding a clarifying comment on how strongly the system enforces the restriction, and whether it affects only the local signup or all providers.

apps/backend/src/api/routes/auth.controller.ts (1)

40-43: Return an HTTP status code that best represents the disabled signup condition.

Using a 400 Bad Request for disabled signup is somewhat generic. Consider returning a 403 Forbidden or a 503 Service Unavailable for better semantic meaning and to accurately describe that the server is refusing signup requests due to configuration.

- response.status(400).json({ error: 'Signup is disabled' });
+ response.status(403).json({ error: 'Signup is disabled' });

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

libraries/helpers/src/configuration/configuration.checker.ts (1)

29-29: LGTM! Consider adding boolean value validation.

The addition of the DISABLE_REGISTRATION environment variable check is good. However, since this is meant to be a boolean flag, consider adding validation to ensure the value is either "true" or "false".

Here's a suggested implementation:

+ checkIsBoolean(key: string, description?: string): boolean {
+   if (!this.checkNonEmpty(key, description)) {
+     return false;
+   }
+   const value = this.get(key)?.toLowerCase();
+   if (value !== 'true' && value !== 'false') {
+     this.issues.push(`${key} must be either "true" or "false". ${description || ''}`);
+     return false;
+   }
+   return true;
+ }

  check() {
    this.checkDatabaseServers()
    this.checkNonEmpty('JWT_SECRET')
-   this.checkNonEmpty('DISABLE_REGISTRATION', 'Set to true to disable signup')
+   this.checkIsBoolean('DISABLE_REGISTRATION', 'Set to true to disable signup')
    this.checkIsValidUrl('MAIN_URL')

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

libraries/helpers/src/configuration/configuration.checker.ts (1)

37-50: Enhance boolean validation robustness and consistency.

While the implementation works, consider these improvements:

1. Handle undefined values explicitly
2. Support case-insensitive comparison
3. Simplify description handling
4. Maintain consistent error message formatting

Here's a suggested implementation:

   checkIsBoolean (key: string, description?: string): boolean {
     const v = this.get(key)
-
-    if (!description) {
-      description = ''
-    }
-
-    if (v !== 'true' && v !== 'false') {
-      this.issues.push(key + ' is not a boolean. ' + description)
+    description = description || ''
+
+    if (!v) {
+      this.issues.push(`${key} not set. ${description}`)
+      return false
+    }
+
+    const normalized = v.toLowerCase()
+    if (normalized !== 'true' && normalized !== 'false') {
+      this.issues.push(`${key} is not a boolean. ${description}`)
       return false
     }

     return true
   }

This implementation:

• Handles undefined values consistently with other methods
• Supports case-insensitive comparison ('TRUE', 'True', etc.)
• Uses template literals for consistent string formatting
• Simplifies the description handling

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro