Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually building gh-ost on go1.16 requires special configuration #933

Closed
natewernimont-wk opened this issue Feb 25, 2021 · 2 comments · Fixed by #966
Closed

Manually building gh-ost on go1.16 requires special configuration #933

natewernimont-wk opened this issue Feb 25, 2021 · 2 comments · Fixed by #966

Comments

@natewernimont-wk
Copy link
Contributor

As of go1.16, go modules are defaulted to be enabled. This means that any consumer manually packaging gh-ost needs to override GO111MODULE. Additionally, go modules are the now standard approach to dependency management in go. It would be nice to move to go modules.
@natewernimont-wk natewernimont-wk mentioned this issue Feb 25, 2021
Closed
2 tasks
@shlomi-noach
Copy link
Contributor

My personal thoughts shared on the PR: #932 (comment)

@timvaillancourt timvaillancourt mentioned this issue May 3, 2021
Merged
2 tasks
@timvaillancourt
Copy link
Collaborator

@natewernimont-wk this is resolved with the merge of #966

Moving to go mod will continue in #966

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add GO111MODULE=off to build.sh, use Golang 1.16 timvaillancourt/gh-ost
3 participants
@shlomi-noach @timvaillancourt @natewernimont-wk