Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Go modules rather than vendored dependencies? #739

Closed
zmoazeni opened this issue May 17, 2019 · 7 comments
Closed

Move to Go modules rather than vendored dependencies? #739

zmoazeni opened this issue May 17, 2019 · 7 comments

Comments

@zmoazeni
Copy link
Contributor

Howdy, if #738 works, I was wondering what the opinions on moving to Go modules were rather than committing the dependencies directly.

I didn't see any existing conversations on this topic.

@zmoazeni
Copy link
Contributor Author

Oh two other notes. This is somewhat related to #727 and would allow us to be able to develop gh-ost outside the GOPATH

@shlomi-noach
Copy link
Contributor

On moving to Go modules: no strong opinions. Since creating orchestrator & gh-ost I've seen so many packaging themes come and go, that I'm glad I didn't commit to any of them previously. I can't say I'm 💯 sure Go modules will be wonderful, but it's the standard now (until the next thing?) so we can try that out.

@zmoazeni
Copy link
Contributor Author

Right on. Yeah I'm hoping modules are here to stay. I do think what you have currently has worked well. I'll work something up and submit a PR.

@zmoazeni
Copy link
Contributor Author

Ah this is going to take some work. There's a few dependencies that have changes that aren't upstream.

@timvaillancourt
Copy link
Collaborator

Go modules has been implemented in #935. Closing this 🎉

@chenrui333
Copy link

@timvaillancourt Any timeline to release the go modules change? Thanks!

@timvaillancourt
Copy link
Collaborator

@chenrui333 this was merged in #935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants