-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to Go modules rather than vendored dependencies? #739
Comments
Oh two other notes. This is somewhat related to #727 and would allow us to be able to develop gh-ost outside the |
On moving to Go modules: no strong opinions. Since creating orchestrator & gh-ost I've seen so many packaging themes come and go, that I'm glad I didn't commit to any of them previously. I can't say I'm 💯 sure Go modules will be wonderful, but it's the standard now (until the next thing?) so we can try that out. |
Right on. Yeah I'm hoping modules are here to stay. I do think what you have currently has worked well. I'll work something up and submit a PR. |
Ah this is going to take some work. There's a few dependencies that have changes that aren't upstream. |
Go modules has been implemented in #935. Closing this 🎉 |
@timvaillancourt Any timeline to release the |
@chenrui333 this was merged in #935 |
Howdy, if #738 works, I was wondering what the opinions on moving to Go modules were rather than committing the dependencies directly.
I didn't see any existing conversations on this topic.
The text was updated successfully, but these errors were encountered: