From 68e2f271809974c39e6a76335bc8c95f5a5ebcd7 Mon Sep 17 00:00:00 2001 From: Ed Minnix Date: Thu, 12 Dec 2024 22:10:15 -0500 Subject: [PATCH 1/2] Add summary `Microsoft.AspNetCore.Components.CompilerServices.RuntimeHelpers::TypeCheck` --- ...crosoft.AspNetCore.Components.CompilerServices.model.yml | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 csharp/ql/lib/ext/Microsoft.AspNetCore.Components.CompilerServices.model.yml diff --git a/csharp/ql/lib/ext/Microsoft.AspNetCore.Components.CompilerServices.model.yml b/csharp/ql/lib/ext/Microsoft.AspNetCore.Components.CompilerServices.model.yml new file mode 100644 index 000000000000..6e99410d98c9 --- /dev/null +++ b/csharp/ql/lib/ext/Microsoft.AspNetCore.Components.CompilerServices.model.yml @@ -0,0 +1,6 @@ +extensions: + - addsTo: + pack: codeql/csharp-all + extensible: summaryModel + data: + - ["Microsoft.AspNetCore.Components.CompilerServices", "RuntimeHelpers", False, "TypeCheck", "(T)", "", "Argument[0]", "ReturnValue", "value", "manual"] From 4ee60138b7118af2a04fc1f8ac2297d07d1ab617 Mon Sep 17 00:00:00 2001 From: Ed Minnix Date: Fri, 13 Dec 2024 12:44:57 -0500 Subject: [PATCH 2/2] Fix test results --- .../test/library-tests/dataflow/library/FlowSummaries.expected | 1 + .../dataflow/library/FlowSummariesFiltered.expected | 1 + 2 files changed, 2 insertions(+) diff --git a/csharp/ql/test/library-tests/dataflow/library/FlowSummaries.expected b/csharp/ql/test/library-tests/dataflow/library/FlowSummaries.expected index a7c87af0bfe0..18728d5198dc 100644 --- a/csharp/ql/test/library-tests/dataflow/library/FlowSummaries.expected +++ b/csharp/ql/test/library-tests/dataflow/library/FlowSummaries.expected @@ -951,6 +951,7 @@ summary | Microsoft.AspNetCore.Components.CompilerServices;RuntimeHelpers;InvokeAsynchronousDelegate;(System.Action);Argument[0];Argument[0].Parameter[delegate-self];value;hq-generated | | Microsoft.AspNetCore.Components.CompilerServices;RuntimeHelpers;InvokeAsynchronousDelegate;(System.Func);Argument[0];Argument[0].Parameter[delegate-self];value;hq-generated | | Microsoft.AspNetCore.Components.CompilerServices;RuntimeHelpers;InvokeSynchronousDelegate;(System.Action);Argument[0];Argument[0].Parameter[delegate-self];value;hq-generated | +| Microsoft.AspNetCore.Components.CompilerServices;RuntimeHelpers;TypeCheck;(T);Argument[0];ReturnValue;value;manual | | Microsoft.AspNetCore.Components.Forms.Mapping;FormValueMappingContext;set_MapErrorToContainer;(System.Action);Argument[0];Argument[0].Parameter[delegate-self];value;hq-generated | | Microsoft.AspNetCore.Components.Forms.Mapping;FormValueMappingContext;set_OnError;(System.Action);Argument[0];Argument[0].Parameter[delegate-self];value;hq-generated | | Microsoft.AspNetCore.Components.Forms;EditContext;GetValidationMessages;(System.Linq.Expressions.Expression>);Argument[0];Argument[0].Parameter[delegate-self];value;hq-generated | diff --git a/csharp/ql/test/library-tests/dataflow/library/FlowSummariesFiltered.expected b/csharp/ql/test/library-tests/dataflow/library/FlowSummariesFiltered.expected index 1d6443748b86..79bc3c9fa8b4 100644 --- a/csharp/ql/test/library-tests/dataflow/library/FlowSummariesFiltered.expected +++ b/csharp/ql/test/library-tests/dataflow/library/FlowSummariesFiltered.expected @@ -164,6 +164,7 @@ | Microsoft.AspNetCore.Components.CompilerServices;RuntimeHelpers;InvokeAsynchronousDelegate;(System.Action);Argument[0];Argument[0].Parameter[delegate-self];value;hq-generated | | Microsoft.AspNetCore.Components.CompilerServices;RuntimeHelpers;InvokeAsynchronousDelegate;(System.Func);Argument[0];Argument[0].Parameter[delegate-self];value;hq-generated | | Microsoft.AspNetCore.Components.CompilerServices;RuntimeHelpers;InvokeSynchronousDelegate;(System.Action);Argument[0];Argument[0].Parameter[delegate-self];value;hq-generated | +| Microsoft.AspNetCore.Components.CompilerServices;RuntimeHelpers;TypeCheck;(T);Argument[0];ReturnValue;value;manual | | Microsoft.AspNetCore.Components.Forms.Mapping;FormValueMappingContext;set_MapErrorToContainer;(System.Action);Argument[0];Argument[0].Parameter[delegate-self];value;hq-generated | | Microsoft.AspNetCore.Components.Forms.Mapping;FormValueMappingContext;set_OnError;(System.Action);Argument[0];Argument[0].Parameter[delegate-self];value;hq-generated | | Microsoft.AspNetCore.Components.Forms;EditContext;GetValidationMessages;(System.Linq.Expressions.Expression>);Argument[0];Argument[0].Parameter[delegate-self];value;hq-generated |