Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify alt-text-bot Workflow #38

Closed
3 tasks
kendallgassner opened this issue Oct 30, 2023 · 4 comments
Closed
3 tasks

Simplify alt-text-bot Workflow #38

kendallgassner opened this issue Oct 30, 2023 · 4 comments

Comments

@kendallgassner
Copy link
Collaborator

What

As pointed out in JoshuaKGoldberg/create-typescript-app#997 the if statement in our alt-text-bot workflow is likely unnecessary.

if: ${{ github.event.issue || github.event.pull_request || github.event.discussion && github.event.comment.user.login != 'accessibility-bot' }}

Acceptance Criteria

  • - Run a test to ensure the if statement is not necessary
  • - Remove if statement from our 'test' workflow
  • - Remove if statement from our readme
@DerTimonius
Copy link

I created a small repo with the if statement removed and created an issue where I added an image without an alt text. There was no comment made by the bot, so I guess the if is necessary?

@kendallgassner
Copy link
Collaborator Author

@DerTimonius I tested this on my end, and it actually just looks like it was due to a version issue in the README. If you bump to 1.4.0 you do not need the if.

@DerTimonius
Copy link

Ah, I see. Thanks for the clarification 🙂

@kendallgassner
Copy link
Collaborator Author

Thanks for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@kendallgassner @DerTimonius and others