Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider fixing issues detected by repository checker #232

Closed
1 task done
ioBroker-Bot opened this issue Sep 11, 2024 · 16 comments
Closed
1 task done

Please consider fixing issues detected by repository checker #232

ioBroker-Bot opened this issue Sep 11, 2024 · 16 comments

Comments

@ioBroker-Bot
Copy link

ioBroker-Bot commented Sep 11, 2024

Notification from ioBroker Check and Service Bot

Dear adapter developer,

I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter e3dc-rscp for common errors and appropiate suggestions to keep this adapter up to date.

This check is based the current head revisions (master / main branch) of the adapter repository

Please see the result of the check below.

ioBroker.e3dc-rscp

Downloads Number of Installations (latest) Number of Installations (stable) - Test and Release

ERRORS:

👍 No warnings found

👍 No suggestions found

Please review issues reported and consider fixing them as soon as appropiate.

Errors reported by repository checker should be fixed as soon as possible. Some of them require a new release to be considered as fixed. Please note that errors reported by checker might be considered as blocking point for future updates at stable repository.

You may start a new check or force the creation of a new issue at any time by adding the following comment to this issue:

@iobroker-bot recheck
@iobroker-bot recreate

Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.

Feel free to contact me (@ioBroker-Bot) if you have any questions or feel that an issue is incorrectly flagged.

And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.

your
ioBroker Check and Service Bot

@mcm1957 for evidence

Last update at Fri, 13 Sep 2024 11:18:35 GMT based on commit cfbcbe1
ioBroker.repochecker 3.0.5

@git-kick
Copy link
Owner

I think this is a false positive.
README.md already has the suggested bottom line.

@mcm1957
Copy link
Contributor

mcm1957 commented Sep 11, 2024

Please copyright clause move to top of license section. See other adapters.

The first copyright detected (and used) is 'Copyright (C) 2007 Free Software Foundation, Inc. https://fsf.org/' Not sure if this is correct at all as fsf holds most likely no copyright at the adapter code. The topmost copyright line should always be the most actual line.

@git-kick
Copy link
Owner

ok. will do so. many thanks!

@git-kick
Copy link
Owner

@ioBroker-Bot recheck

@ioBroker-Bot
Copy link
Author

This issue has been updated by ioBroker Check and Service Bot

RECHECK has been performed as requested.
No changes detected.

@git-kick
Copy link
Owner

The first copyright detected (and used) is 'Copyright (C) 2007 Free Software Foundation, Inc. https://fsf.org/' Not sure if this is correct at all as fsf holds most likely no copyright at the adapter code. The topmost copyright line should always be the most actual line.

The 2007 fsf copyright is part of the license text, which I included unchanged.

@git-kick
Copy link
Owner

@ioBroker-Bot recheck

@ioBroker-Bot
Copy link
Author

This issue has been updated by ioBroker Check and Service Bot

RECHECK has been performed as requested.
No changes detected.

@git-kick
Copy link
Owner

@ioBroker-Bot recheck

@ioBroker-Bot
Copy link
Author

This issue has been updated by ioBroker Check and Service Bot

RECHECK has been performed as requested.
No changes detected.

@git-kick
Copy link
Owner

@ioBroker-Bot recheck

@mcm1957
Copy link
Contributor

mcm1957 commented Sep 13, 2024

Please see #234
This PR should fix the issue.

The copyright line must be at top of license section - not before the license section. :-)

@ioBroker-Bot
Copy link
Author

This issue has been updated by ioBroker Check and Service Bot

RECHECK has been performed as requested.
No changes detected.

@git-kick
Copy link
Owner

@ioBroker-Bot recheck

@ioBroker-Bot
Copy link
Author

This issue has been updated by ioBroker Check and Service Bot

The following issues have been fixed
[E605] No actual year found in copyright. Please add "Copyright (c) 2024 Ulrich Kick [email protected]" at the end of README.md

👍Thanks for fixing the issues.

RECHECK has been performed as requested.

@ioBroker-Bot
Copy link
Author

All issues reported earlier seem to be fixed now.
THANKS for your support.
This issue will be closed.

your
ioBroker Check and Service Bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants