installer: really default to Secure Channel #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 8a7ab99 (installer: switch the libcurl default to Secure Channel, 2023-05-15) attempted to change the default libcurl backend for clean new installs to Secure channel, but only adjusted one of two fallbacks in the installer. There is one default value that gets passed to ReplayChoice() to return if it finds no previous choice and one value that gets used if ReplayChoice() returns an unexpected value. 8a7ab99 changed the latter to use Secure Channel, but left the former to default to OpenSSL. Adjust the default value to match the intention of that patch. This fixes git-for-windows/git#5295 Signed-off-by: Matthias Aßhauer <[email protected]>
dscho
approved these changes
Jan 4, 2025
|
/add relnote feature New Git for Windows installation now default to the Windows-native HTTPS transport backend. The workflow run was started |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 4, 2025
New Git for Windows installation [now default to the Windows-native HTTPS transport backend](#586). Signed-off-by: gitforwindowshelper[bot] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 8a7ab99 (installer: switch the libcurl default to Secure Channel, 2023-05-15) attempted to change the default libcurl backend for clean new installs to Secure channel, but only adjusted one of two fallbacks in the installer. There is one default value that gets passed to ReplayChoice() to return if it finds no previous choice and one value that gets used if ReplayChoice() returns an unexpected value. 8a7ab99 changed the latter to use Secure Channel, but left the former to default to OpenSSL. Adjust the default value to match the intention of that patch.
This fixes git-for-windows/git#5295