Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataBrowser loading state transition improvement. #180

Open
subdavis opened this issue Oct 8, 2019 · 1 comment
Open

DataBrowser loading state transition improvement. #180

subdavis opened this issue Oct 8, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@subdavis
Copy link
Contributor

subdavis commented Oct 8, 2019

background

Originally, DataBrowser would show a single row of "No data available" during load. I changed this intentionally because, when girder response times are quick, it caused the entire component (and potentially the page) to flicker in an undesirable way.

Now, during load, the old directory contents stick around until the new ones are ready. This doens't look right at slow speeds.

Changes requested:

  • When navigating between a meta-directory (like users) where there are never check boxes and a real directory, don't show checkboxes until the new contents load.
  • During load, disable check and click behavior.
@subdavis subdavis added the bug Something isn't working label Oct 8, 2019
@zachmullen
Copy link
Member

During load, disable check and click behavior.

Ideally, this should be done in a visually obvious way so that the user realizes they're looking at the old directory contents and not the new one, since there will be a temporary mismatch with the breadcrumb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants