-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Not Now" does nothing #86
Comments
I'm having the same problem. Same extension and Chrome version on Mac |
Bug verified, sorry for the inconvenience. We will fix this in a next version. |
This workaround only works if there's another tab in the current window. Very strange indeed! :) |
I was going to write that this workaround doesn't work for me, but it seems that it does. The icon changes to gray but the text remains the same. That is very good to know, thank you! |
That's the behavior I've been seeing: TMS 7.1.6.2 |
Tengo el mismo problema. "Not now" no funciona. Hago click, pero no sucede nada.-I have the same problem. "Not now" doesn't work. I click, but nothing happens. Chrome Versión 90.0.4430.93 (Build oficial) (64 bits) |
I also have the same issue. TMS Version 7.1.6.2 |
Ciao @S1rK , I can understand the frustration but, since I was infected by Covid-19 and @sherkot was "temporarily out of the game" because he has meanwhile married, We haven't had a chance to rework the code to fix the various problems you have reported. This will change shortly, we already agreed to work on the reported problems, to release a new version of TMS that will correct them and introduce some of the requested improvements. Thanks for your patience, I remind everyone that the code is completely open and is welcome the help of other developers who want to try to solve the issues reported. |
First of all, @gioxx, take care of your health and I hope you'll get better soon! |
Hope you are well now, @gioxx. (And @sherkot still happily married.) This seems like a good time to ask what "Not Now" actually means. That is, when does "Not Now" revert to the user's chosen default setting? An actual definition of "Not Now" would be useful to have to better determine whether, in specific situations, it's the better option to choose, rather than the more permanent one ("Never suspend this URL"). Also suggest that the "Suspend all other tabs" and "Unsuspend all tabs" options include the words "in this window" since otherwise "all" would tend to mean "in all open windows." Thanks. |
@gioxx @sherkot Also, before 'closing' this, a reply to the questions in my post would be appreciated. Thanks. |
Yeah, I've avoided using that option for exactly that reason: not knowing what it does (with my tons of windows and tabs) made it seem like a potentially dangerous option. ;) |
@mkz7: The fix first needs to be published in a release on the extension store. Did you install the extension from the source code in this repo? "Not Now" means, "Don't suspend this tab now", and that is obvious if you think about what the extension does. Edit: deleted something regarding something that I might have misinterpreted... |
Hi @d4h0, you are reading something into my post which wasn't in it. There was no rudeness present or intended.
It appears I wasn't clear about my question re: the meaning of "Not Now."
What I meant to ask was what the '**technical**' meaning of that condition is -- that is, yes it's clear that it means that at the current time ("Now") the tab won't suspend -- but at what point, or under what conditions, does a "Not Now" tab revert to the user's default setting for when tabs do suspend (e.g., after one hour of inactivity, etc.)?
To put it another way, what exactly makes a "Not Now" tab suspend without any user intervention. It makes sense that "Not Now" is temporary, since otherwise the setting would be no different from "Never suspend". But what triggers the tab's reverting to a 'suspended' state isn't stated anywhere as far as I'm aware.
Thanks.
On Friday, May 28, 2021, 02:35:42 PM EDT, d4h0 ***@***.***> wrote:
@mkz7: The fix first needs to be published in a release on the extension store. Did you install the extension from the source code in this repo?
"Not Now" means, "Don't suspend this tab now", and that is pretty obvious if you think about what the extension does.
Besides that: Your message seems pretty rude. You should think about how you talk to people who work for free on projects you use. This behavior is discouraging to the maintainers.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@mkz7: Alright. After publishing my comment and then rereading what you wrote, I came to the same conclusion (see my edit above).
Okay, that wasn't clear to me. But I wondered the same in the past. I never noticed that "Not now" was reverted automatically – but I'm pretty sure that I read somewhere that it would. So a clarification would be great.
I'm pretty sure, restarting the browser does clear the "Not Now" mark of a tab. But, as I wrote, some documentation would be great. |
Ciao @mkz7, I can confirm we have solved the problem in the GitHub version of TMS, you have to wait "public" TMS 7.1.6.3 if you use the Chrome Store version (and we want to solve other problems and introduce Tab Group's save / export before push the new version on Google, we hope as soon as possible). In the meantime, I can reply to the doubt about "Not Now" function. "Not Now" use a temporary whitelist who permit to mantain open and not suspended tabs. If you exit from the browser, tabs previously set to "Not Now" will reset and get suspended as usual. The same behaviour you can obtain if you close the tab and open again (without using CTRL+SHIFT+T). If you want to save this condition, you have to use "Never suspend this url" (or domain). If you want some other technical details, I think @sherkot can reply better than me. |
"do not suspend this tab" would be clear enough in both spatial and temporal scope. the problem is that this wouldn't really fit with the preceding part of the menu item, which is actually a status message. i guess one could address this by separating the two, thus turning the status into a passive title, and having a proper context-sensitive additional menu item right below it instead. |
Thanks, @gioxx (cc: @sherkot). > you have to wait "public" TMS 7.1.6.3 if you use the Chrome Store version (and we want to solve other problems and introduce Tab Group's save / export before push the new version on Google, we hope as soon as possible). Is there a way to install the update now from Github? I'm not particularly 'technical' (as most users here seem to be) but I can follow instructions if the procedure is a simple one. > "Not Now" use a temporary whitelist who permit to mantain open and not suspended tabs. If you exit from the browser, tabs previously set to "Not Now" will reset and get suspended as usual. Okay, so the only difference is that "Never suspend" persists following a browser exit, whereas "Not Now" doesn't? |
Of course! Now you can download the current TMS (updated on GitHub) via https://github.com/gioxx/MarvellousSuspender/archive/refs/heads/master.zip. Unzip the archive and load an unpacked extension in Chrome:
Now you have TMS 7.1.6.2 installed from GitHub, the modified version (actually a work in progress), you can suspend all tabs again or (if you have lose some tabs), you can import the saved session
Exactly. |
Is a good suggestion that we will evaluate when improving the extension, thanks. |
@mkz7 I personally have no problem releasing a new update on the Chrome Store, even if only to fix a bug. Unfortunately though, as already reported in this comment (#86 (comment)) I find myself having to suffer complaints due to the update that goes to disturb the activity of users. For this reason I would like to release one that is as complete and stable as possible and that already corrects several aspects of TMS. |
@gioxx have you tried making the upgrade less of a PITA? i already discussed that back with dean, and he liked my idea(s) (find them in the TGS tracker). i thought he implemented it already, but apparently not (fully)? |
It's weird, amd even more so b'cuz of the workaround of switching back and forth the tabs makes it work. Also, the same behavior seems to happen when clicking "Pause/unpause suspension of this tab" from TMS submenu in right-click context menu... |
@gioxx What I am noticing is that the 'switch-to-another-tab-then-back-to-the-tab-you-want-temporarily-suspended' trick (i.e., the workaround to activate 'Not now') does not seem to actually be doing that. The tab's icon grays out when that sequence is performed, making it appear that the tab won't suspend. However, checking the status of the tab (by clicking on the TMS icon), I find that "Tab will suspend automatically. Not now" still displays. So the actual status of the tab via the workaround is unclear. If it is actually already in a 'Not now' state, the option to select that should not display. |
I'm also experiencing this issue, although the status of the tab's suspension seems to be accurate, ie the icon is greyed out and the status reads as 'Tab suspension paused. Unpause' when clicking on the icon. @gioxx I just wanted to check on the status of the update to the Chrome Web Store version. The last timing estimate was 'during the summer' and now it's almost September. Not rushing y'all at all, just curious about an updated time estimate. I can figure out how to install the GitHub version if the CWS update is still a ways off. |
Just to be clear, the 'switch away and then back' process that it was claimed would achieve the 'Not now' state was said to be induced by the following sequence: Click on 'Not now' -- nothing happens. Is that correct? (That's what I'm finding is not happening.) |
ciao @mkz7 and @witcheries, the problem is manifest v3, unfortunately we've suffered a slowdown in the migration and @napolux is overwhelmed with work, which is why we haven't been able to publish an updated version of TMS for the Chrome Store that solves the reported problems and introduces those new features we've been talking about. Although I understand that an "intermediate" release is certainly welcome, I'm convinced that the novelty regarding the update system (that doesn't disturb you users in case of updates) is fundamental to land on the Chrome Store with the new version. Feel free to install the GitHub version, while waiting the good news about the next official and stable version released on the Chrome Store. Thanks (really) for all the support and patience. |
I'm sorry to raise this again, but it's mid-October and "Not Now" - a feature I use(d to use) on a daily basis - still isn't working, and finding this thread is the only reason I didn't uninstall the extension today. I'm happy to continue being patient for an approximately-known timeframe, if you have one, for the Chrome Store? Otherwise I'll probably join others (above) in switching to the Github version. Thank you for your work in creating this extension, for making it open source, and in somehow remaining positive and friendly in response to feedback -- even when some of the commenters haven't really deserved it! |
@digitalambition: What I'm doing at the moment is to just use the 'Never suspend this URL' feature (which works). From time-to-time I go to the settings page and delete everything from the 'Never suspend tabs with URLs from the following list' text area. This works well enough for me at the moment, but I still would love to get the 'Not now' feature back... :) |
Ciao @gioxx . . . Was TMS 7.1.6.3 ever uploaded to the Chrome Store? |
@gioxx In this post from last August -- #86 (comment) -- I mentioned that the issue wasn't limited to 'Not now' not working when clicked, but that the temporary solution of clicking another tab and then clicking back to the original tab also does not work. I can document that what I reported then continues to occur, with an example: – I select 'Not now' for a tab. It has no effect. The TMS icon remains 'brown' (i.e., the tab will 'suspend' according to currently-selected 'suspend' setting). The gray normally indicates a 'whitelisting' state (meaning the tab should not 'suspend'). Given the sequence mentioned above, it should now be in the 'Not now' state, not the 'Never' state. Note, however, that the icon, though gray, when clicked still offers 'Not now' -- which normally would mean the tab is not whitelisted and will suspend according to the default (or otherwise currently-selected) 'suspend' setting. – Within several minutes, the gray tab reverts to 'brown'. This does take several minutes to occur -- i.e., the icon temporarily displays as gray per the previous step, but invariably it does revert to brown after a delay. This reflects the actual state of the tab. No ability to induce 'Not now' through tab switching actually works. |
That's correct, although the second tab didn't need to be live. It could also be suspended, and the workaround would still work. However, I'm now noticing that the 'Not now' is working as expected, so I wonder if a fix was released? |
> I'm now noticing that the 'Not now' is working as expected, so I wonder if a fix was released? I'm not seeing any difference, myself. I click on "Not now' and nothing happens. And as noted in the post you replied to, even the workaround was no longer working (which continues to be the case for me). |
Ciao @mkz7, sorry for the late reply. No, TMS 7.1.6.3 has not been uploaded to the Chrome Store because I want to avoid the negative comments from those who would go and lose the tab groups, as mentioned several times. I'm struggling with development because what's being imposed on us by Chrome's Manifest V3 is preventing us from working as we'd like, and we're not sure we can move TMS forward. That said, we will try to focus on saving Tab Groups so we can integrate it with Manifest V2 (I seem to remember it wasn't possible but we'll look at it again) and thus release a good updated version that allows everyone to work properly. I don't have any release forecasts on this but we are doing what we can in the little spare time to get the task done. If there were more developers out there that could help us, that would be great and allow us to speed up. Up to now the best solution maybe remains to use the version released here on GitHub (although I realize that you lose the convenience of letting Chrome update it by taking it directly from its Store). |
> I want to avoid the negative comments from those who would go and lose the tab groups Thanks, @gioxx. I didn't follow the 'tab groups' issue but couldn't TMS users just be advised to use another extension that saves tab groups until you're able to implement that feature in an updated TMS? (e.g., they could use Tabli for that, which saves tab groups as bookmarks) If I were to opt to use the Github version, is it necessary to 'uninstall' the current Chrome version or can it just be 'disabled' on the extensions page (red button on the far right)? If not, by 'uninstall' do you just mean use the 'remove' button? Also, re the last instruction in your 'how to' post -- "Load the "src" folder" -- how is that done? I assume you don't do it by using the same "Load unpacked" button used for the prior instruction (or do you?) . . . #86 (comment) Thanks again. |
Hi @gioxx, I mentioned Tabli (another tab management extension) in my last post -- as a way that TMS users could save tab groups until you can incorporate that feature in TMS. I've since recalled that Tabli's developer had included support for The Great Suspender. When the 'issues' with TGS happened, he indicated that he would do the same for any fork by a "trustworthy developer". So you could contact him to do that with TMS if you would like that to happen. Tabli provides 'bookmarking' of tab groups, so the TMS users who want that feature could get it in an interim way from Tabli. You could then (if you want to) get a current update of TMS into the Chrome Store for your users, one that includes the 'Not now' fix, and leave the 'tab groups' issue for later. Just a thought. TABLI . . . https://chrome.google.com/webstore/detail/tabli/igeehkedfibbnhbfponhjjplpkeomghi Antony Courtney [email protected] |
No offense, but it's coming up on a full year since this rather simple code fix was implemented in the github source via/unpack version, yet a year later a MAJOR bug like this still isn't pushed to the Chrome store? I can guarantee that the "complaints" you were facing by releasing this fix, then the other updates, has been FAR exceeded now by those using the webstore extension where one of the few features this extension offers - is 100% broken. I'm curious what metric has you so convinced that releasing two releases, this hotfix, then whatever you've been working on for session mgmgt, would cause the sky to fall to that extent for TMS users? BTW, I've been using TGS since day one, and NEVER use the session mgmt because for that, I use Session Buddy, which provides session mgmt to a level that TGS/TMS will never possibly achieve - and that's ALL it does. Anyone can install that, save their sessions import/export etc. and never need to worry about "losing" TMS sessions - it's what I do. ALL I want TGS/TMS to do, is tab suspension - and to do it well - that's it. |
This is still an issue for me as well. |
@mkz7 Uninstallation of the web store version is not required, but disabling it is. If you install the GitHub release any currently suspended tabs will disappear, so be mindful of that. Unsuspend and load them all beforehand, then save the session before continuing with the installation. Tablii already has an open issue for that here: antonycourtney/tabli#159 and a pull request including TMS ID here: antonycourtney/tabli#165 |
@Technetium1 Thanks, Courtney's posts date back quite a while. I doubt he is even involved at all with #159 and #165 at this point. Given the length of time the 'Not now' issue has remained outstanding, I've concluded that @gioxx is just not going to get to fixing it in the Chrome store version. Appreciate the information (especially the warning) about the GitHub installation. |
@CollinChaffin Saving sessions in TMS seems straightforward enough. Can you say a bit about what makes Session Buddy superior for that purpose? In the past, every time I looked at the user posts regarding Session Buddy issues, there were a great many complaints about lack of response from the developer. Has that changed? Thanks. |
Same :(
Other similar extensions like
Works fine. |
This is still an issue for me but it is inconsistent. Sometimes it works, other times it does not. |
Still having this on |
It's 2024 and the "not now" button has never worked for me, with or without workarounds |
Used to work for me but now it stopped, unfortunate. |
When deciding not to suspend a certain tab, and clicking on the "Not Now" button in the extension window, nothing happens.
I could help provide some logs or something if you tell me how it should be done.
Also, thanks for taking control of this extension!
The text was updated successfully, but these errors were encountered: