New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New list created by check_point_clouds even when copy=False #431

Open

ulupo opened this issue Jul 14, 2020 · 0 comments

Labels

Contributor

ulupo commented Jul 14, 2020 •

edited

Loading

It seems that the input is systematically copied and returned. In sklearn, there is a copy boolean argument to the check_array function. This is especially useful if one of the function in transform is already returning a copy of the sample or if it does not modify the input at all.

Originally posted by @gtauzin in https://github.com/_render_node/MDIzOlB1bGxSZXF1ZXN0UmV2aWV3VGhyZWFkMjc2ODE3ODEwOnYy/pull_request_review_threads/discussion

The reason for this situation is explained in my responses #424 (comment) and #424 (comment). However, a better solution may be found.

The text was updated successfully, but these errors were encountered:

ulupo added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment