You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
16:45 #diagrams: < Martingale> notdan why did you write colorToJSRGBA for ghcjs instead of just using colorToSRGBA and multiplying the first 3 numbers by 255, from a quick read of the code it seems like they would have the same effect?
The text was updated successfully, but these errors were encountered:
Mostly notes to myself on the status of this issue:
I agree that colorToJSRGBA is equivalent to what @jeffreyrosenbluth describes. I think from the IRC discussion that better inlining was the original motivation for moving this here. I suspect that since this commit the speed isn't much of an issue. But I'm not sure how to profile GHCJS programs, and I'd rather do that before making the change.
https://github.com/ghcjs/diagrams-ghcjs/blob/master/src/Graphics/Rendering/GHCJS.hs#L157
16:45 #diagrams: < Martingale> notdan why did you write colorToJSRGBA for ghcjs instead of just using colorToSRGBA and multiplying the first 3 numbers by 255, from a quick read of the code it seems like they would have the same effect?
The text was updated successfully, but these errors were encountered: