Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate colorToJSRGBA #5

Open
co-dan opened this issue Jan 26, 2014 · 1 comment
Open

Investigate colorToJSRGBA #5

co-dan opened this issue Jan 26, 2014 · 1 comment
Assignees

Comments

@co-dan
Copy link
Member

co-dan commented Jan 26, 2014

https://github.com/ghcjs/diagrams-ghcjs/blob/master/src/Graphics/Rendering/GHCJS.hs#L157

16:45 #diagrams: < Martingale> notdan why did you write colorToJSRGBA for ghcjs instead of just using colorToSRGBA and multiplying the first 3 numbers by 255, from a quick read of the code it seems like they would have the same effect?

@ghost ghost assigned co-dan Jan 26, 2014
@bergey
Copy link
Contributor

bergey commented Aug 19, 2015

Mostly notes to myself on the status of this issue:

I agree that colorToJSRGBA is equivalent to what @jeffreyrosenbluth describes. I think from the IRC discussion that better inlining was the original motivation for moving this here. I suspect that since this commit the speed isn't much of an issue. But I'm not sure how to profile GHCJS programs, and I'd rather do that before making the change.

@bergey bergey removed the question label Aug 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants