Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizing in iOS doesn't work correctly after #6107 #7011

Open
HackerFoo opened this issue Jan 27, 2025 · 4 comments · May be fixed by #7026
Open

Resizing in iOS doesn't work correctly after #6107 #7011

HackerFoo opened this issue Jan 27, 2025 · 4 comments · May be fixed by #7026
Labels
area: wsi Issues with swapchain management or windowing backend: metal Issues with Metal platform: ios Issues with integration with ios type: bug Something isn't working

Comments

@HackerFoo
Copy link

Description
Resizing is broken in iOS after #6107 in Bevy. See bevyengine/bevy#16604 for details.

Repro steps
This can be reproduced with Bevy's mobile example (in examples/mobile) - make run to launch the app in the simulator, and then rotating the screen shows cropped/stretched graphics.

Expected vs observed behavior
No distortion when rotating the screen.

Platform
iOS, using Bevy

@cwfitzgerald
Copy link
Member

cc @madsmtm as probably the most aware metal person

@cwfitzgerald cwfitzgerald added type: bug Something isn't working backend: metal Issues with Metal area: wsi Issues with swapchain management or windowing platform: ios Issues with integration with ios labels Jan 28, 2025
@madsmtm
Copy link
Contributor

madsmtm commented Jan 28, 2025

Yeah, turns out I was wrong in a few areas when making #6107.

I suspect that #6210 would fix it, but that may take some time, so I guess what I'll do to fix this depends on when you think objc2-metal/#5641 might land?
If ~soon, then we can just merge the aforementioned PR, if not, then I might be persuaded to re-implement the approach that raw-window-metal uses using just objc (but that is a lot of tedious work).

@madsmtm
Copy link
Contributor

madsmtm commented Jan 29, 2025

Tested the Bevy example now, I can reproduce on Bevy v0.15.1 / Wgpu 0.23, and the issue would be fixed with #6210.

I realize that it's kinda rude to keep pestering you about objc2, so I'm working on a re-implementation for raw-window-metal in wgpu using just objc - it won't be pretty, but it will be.

@madsmtm madsmtm linked a pull request Jan 29, 2025 that will close this issue
5 tasks
@madsmtm
Copy link
Contributor

madsmtm commented Jan 29, 2025

Done in #7026.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: wsi Issues with swapchain management or windowing backend: metal Issues with Metal platform: ios Issues with integration with ios type: bug Something isn't working
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

3 participants