Attachments support is not provided?

[prasadKodeInCloud]

Hi,

Could not send attachments as per the documentation in npm 'mailgun-js' package. https://www.npmjs.org/package/mailgun-js

This feature is not implemented yet?

[marcodejongh]

@prasadKodeInCloud Attachments is not yet implemented.

I think I can implement it for you somewhere this week. If you can not wait feel free to fork this project and implement it yourself and creating a pull request for the changes

[prasadKodeInCloud]

@marcodejongh Thanks for the reply. Glad if you can implement it in this week.

[marcodejongh]

@prasadKodeInCloud Im not gonna be able to add extra features for a while because its somewhere low on our backlog. But feel free to fork and add the feature yourself

[jerefrer]

Any news on this ? I'd love to be able to choose the name of the attached file ;)

[marcodejongh]

@jerefrer The send method of this packages is just a simple wrapper around mailgun-js taking care of a lot of oddities in the mailgun api. I've never aspired to wrap the whole of the mailgun-js api that's why I left a non private reference to the internal instance of the mailgun-js instance. This api reference you can use for stuff that isn't wrapped (yet).

So the following should work:

var readFile = Meteor.wrapAsync(Npm.require('fs').readFile)
var path = Npm.require('path');
var filename = 'mailgun_logo.png';
var filepath = path.join(__dirname, filename);

var file = readFile(filepath);

var attch = new MailgunInstance.api.Attachment({data: file, filename: filename});

var data = {
  from: 'Excited User <[email protected]>',
  to: '[email protected]',
  subject: 'Hello',
  text: 'Testing some Mailgun awesomness!',
  attachment: attch
};

mailgunInstance.send(data);

But I do agree it's a decent request and I will definitely add wrapper code handling attachments in the future.

[jerefrer]

Haven't time to try this just now but if Attachment is accessible is should work just fine. That's all I needed thank you :)

If you don't have time to implement it properly maybe you could document this on the README for everyone to see ?

[marcodejongh]

@jerefrer Done, I've also updated the workaround to use a fiber instead of a sync readFile..

Could you tell me if it works when you do try it?

[jerefrer]

I sure will but it won't be before a week or so. Thanks for the doc, doc :)

[shkomg]

it'd be great to have it working but it doesn't work like that.

it even just doesn't works when I supply file data as Buffer object to the attachment property.

Any ideas?

Your help is really needed!

Thank you.

[marcodejongh]

@shkomg What is the error you get?

[shkomg]

@marcodejongh

I got no error - email is send but with no attachment.

Here is the code (i'm sending the PDF out);

        var toc = new PDFDocument({size: 'A4', margin: 50});
        toc.fontSize(12);
        toc.text('Invoice', 10, 30, {align: 'center', width: 200});
        toc.writeSync(path);

        var readFile = Meteor.wrapAsync(Npm.require('fs').readFile)
        var file = readFile(path);

        Meteor.Mailgun.send({
            to: doc.email,
            from: doc.from,
            subject: 'Invoice for your ad campaign',
            text: message,
            html: Handlebars.templates['contactEmail']({siteURL: Meteor.absoluteUrl(), fromName: doc.name, fromEmail: doc.from, message: message}),
            attachment: file
        });

And when I tried previously proposed solution I can't reach MailgunInstance.api.Attachment

[marcodejongh]

@shkomg With MailgunInstance I meant the pointer to the instance of mailgun.

So it looks like you keep a instance of mailgun on Meteor.Mailgun. So in your case you should use Meteor.Mailgun.api.Attachment.

[shkomg]

@marcodejongh

ok, when I do this var attch = new Meteor.Mailgun.Attachment({data: file, filename: "invoice.pdf"});

Meteor throws error:

Exception while invoking method 'getInvoice' TypeError: undefined is not a function

[marcodejongh]

@shkomg You have a getInvoice method somewhere?

[shkomg]

@marcodejongh

yes, all this code is in getInvoice method & that error points on this string: var attch = new Meteor.Mailgun.Attachment({data: file, filename: "invoice.pdf"});

It happens so that Meteor.Mailgun is an object and it just doesn't have Attachment method.

I also have tried to use just new Mailgun.Attachment and new Mailgun({api key & domain}).Attachment - all these are objects without Attachment method

[marcodejongh]

@shkomg Try:

var attch = new Meteor.Mailgun.api.Attachment({data: file, filename: "invoice.pdf"});

[shkomg]

@marcodejongh

here it is TypeError: Cannot read property 'Attachment' of undefined

[marcodejongh]

@shkomg
This should definitely work:
new Mailgun({api key & domain}).api.Attachment

[shkomg]

@marcodejongh it works - it send's email but with no attachment :(

[marcodejongh]

@shkomg Ok I'll add the support the mailgun this weekend that will make it a lot easier

[shkomg]

@marcodejongh that'd be awesome!

Thank you!

[shkomg]

@marcodejongh Great, that change in readme works! Thank you.

[marcodejongh]

@shkomg Thank you for testing my readme.md ;)

[quape]

I tried to add an attachment with:

'attachment': new mg.api.Attachment({data: Assets.getBinary('logo.png'), filename: 'logo.png'})

wich did not work. The mail was sent but without attachment.

Secondly, if I can make it work, is it possible to mark the attachment as an inline attachment? It's for inline images with are not shown as attachment files in the mail app.

Thanks