Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hyperlinks with .x suffix are not recognized #1167

Closed
stho opened this issue Jan 3, 2025 · 1 comment · Fixed by #1169
Closed

Hyperlinks with .x suffix are not recognized #1167

stho opened this issue Jan 3, 2025 · 1 comment · Fixed by #1169
Labels
bug low-hanging-fruit "Easy picks" suitable for new contributors to tackle reproducible-in-git Issues that affect the current dev version

Comments

@stho
Copy link
Contributor

stho commented Jan 3, 2025

If I add a new hyperlink to a task. It is not fully recognized as link.

https://ticketsystem.company.x/issues/65432 will create a link to https://ticketsystem.company

image
@gycsaba96
Copy link
Contributor

The bug is reproducible in the current git version. It seems that the corresponding regexp requires that domains are at least 2 characters long. Accordingly, x.com is also not detected.

@nekohayo nekohayo added bug low-hanging-fruit "Easy picks" suitable for new contributors to tackle reproducible-in-git Issues that affect the current dev version labels Jan 3, 2025
stho added a commit to stho/gtg that referenced this issue Jan 6, 2025
@stho
Allow shorter domain suffix for just one character
4110a0f 
- FIX: Allow shorter domain suffix for just one character
- FEATURE: Add unit test for checking short domain suffix

refs getting-things-gnome#1167
@stho stho mentioned this issue Jan 6, 2025
Merged
stho added a commit to stho/gtg that referenced this issue Jan 7, 2025
@stho @SqAtx
Use a more simple regex
16a2163 
refs getting-things-gnome#1167

Co-authored-by: Kevin <[email protected]>
diegogangl pushed a commit that referenced this issue Jan 9, 2025
@stho @diegogangl
Allow shorter domain suffix for just one character
ba3dbde 
- FIX: Allow shorter domain suffix for just one character
- FEATURE: Add unit test for checking short domain suffix

refs #1167
diegogangl pushed a commit that referenced this issue Jan 9, 2025
@stho @SqAtx @diegogangl
Use a more simple regex
6ea94b9 
refs #1167

Co-authored-by: Kevin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug low-hanging-fruit "Easy picks" suitable for new contributors to tackle reproducible-in-git Issues that affect the current dev version
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow shorter domain suffix for just one character stho/gtg
3 participants
@nekohayo @stho @gycsaba96