feat(sveltekit): Respect user-provided source map generation settings #14885 #14886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chargome
reviewed
Jan 2, 2025
Lms24
reviewed
Jan 2, 2025
There was a problem hiding this comment.
I thought about moving this parts of this logic to the sentryVitePlugin in general.
This sounds reasonable to me. The base plugin's deletion behaviour is also problematic on its own as reported in #14131. I'm looking into this right now but maybe the answer really is to just handle deletion within our sentrySvelteKit Vite plugin
| }; | ||
| }, | ||
| sentryPluginOptions?: CustomSentryVitePluginOptions, | ||
| ): UserSourceMapSetting { |
There was a problem hiding this comment.
I see that we don't use this return value other than in tests. We'll need the return value for when we can automatically configure filesToDeleteAfterUpload, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables
hiddensource maps if source maps are unset. In case they are explicitly disabled or enabled the setting is kept as is.Still need to figure out how to set
filesToDeleteAfterUploadas this setting needs to be passed when "calling" the sentry Vite plugin. However,filesToDeleteAfterUploadis dependent on the Vite options and we only have access to the Vite options when creating the custom plugin.I thought about moving this parts of this logic to the
sentryVitePluginin general.closes #14885