-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ~/
as default url_prefix
#137
Comments
~/
as default url_prefix~/
as default url_prefix
Run into the same issue recently, Github Action should indeed have the same defaults as the CLI ! |
Took me two days and a thread in your Discord to figure this out. Please consider this issue. |
When implementing this, we should not hardcode the default URL prefix as |
Creating the expected behavior with less code is always to be preferred :-) |
I have just experienced (the hard way) that url_prefix is set to
~/
by default in the CLI but empty in the github action.This has generated additional friction for us to set up our source-maps properly: we initially tried with the CLI and everything worked like a charm, then realized the action behaved differently.
Having both consistent (and using
~/
rather than none, because I guess it is the most common value) would probably make the setup smoother for most people.The text was updated successfully, but these errors were encountered: