Landing code on master should not produce a new image

[armenzg]

Currently, almost any code landing on master will produce a new Docker image tagged as latest which all users of the action will immediately start using.

We need to have control as to when releases happen.

We should only release on tag changes as suggested by @asottile-sentry

As you can see, the commits below are not code changing, thus, it should not produce a new image

As a side note, to my surprise, the caching gets invalidated with COPY package.json yarn.lock /action-release :
https://github.com/getsentry/action-release/runs/7567494647?check_suite_focus=true#step:4:51
Before, we used to copy it from the builder image.

[bc-sentry]

@armenzg Please confirm, but I believe this issue was resolved with the Sentry GoCD deployment pipeline.

[asottile-sentry]

that doesn't make sense: there's no gocd pipeline for this repo

[armenzg]

As Anthony mentions, it does not apply here. This issue is still valid.

[bc-sentry]

Thanks. I was thinking this was referring to code in other repos that would be released by this action, not the update to this action itself. Do we have any other GHA repos that have this controlled release suggested (ie. We should only release on tag changes)? Has lack of this control created pain in the past 2+ years (ie. should we prioritize doing this work)?

[armenzg]

It has not caused pain.
It's more of the ideal release process.

The web SDK is also looking to maintain this repo.

Perhaps we wait for them to prioritize the work and let them ask for support where needed.