Skip to content
This repository has been archived by the owner on Sep 9, 2024. It is now read-only.

Use custom schema when redirecting back from OAuth flow #56

Closed
jornane opened this issue Sep 30, 2020 · 1 comment · Fixed by #55
Closed

Use custom schema when redirecting back from OAuth flow #56

jornane opened this issue Sep 30, 2020 · 1 comment · Fixed by #55
Assignees
@jornane @pauldekkers
Labels
android Android related apple iOS/MacOS related enhancement New feature or request
Milestone
Compliance

Comments

@jornane
Copy link
Member

jornane commented Sep 30, 2020

Related to #55, when redirecting back from the OAuth flow, the app currently receives the authorization_code on http://localhost:8080/. It would be better if we use a custom URL schema for this on the mobile platforms, such as letswifi://auth_callback.
@jornane jornane added enhancement New feature or request apple iOS/MacOS related android Android related labels Sep 30, 2020
@jornane jornane mentioned this issue Sep 30, 2020
Merged
@jornane jornane added this to the Compliance milestone Oct 9, 2020
@jornane jornane linked a pull request Oct 24, 2020 that will close this issue
Use "custom tabs" functionality to use the default browser for OAuth flow #55
Merged
@jornane
Copy link
Member Author

jornane commented Oct 24, 2020

Fixed in #55

@jornane jornane closed this as completed Oct 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jornane jornane

@pauldekkers pauldekkers

Labels
android Android related apple iOS/MacOS related enhancement New feature or request
Projects
None yet
Milestone
Compliance
Development

Successfully merging a pull request may close this issue.

Use "custom tabs" functionality to use the default browser for OAuth flow geteduroam/ionic-app
2 participants
@jornane @pauldekkers