-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Italic and underline didn't work in neovim #1
Comments
Hi, Karmenzind. Keep in mind there are two versions of atomic colorscheme for vim/neovim at this moment, the version 3.0 and the version 3.1. The version 3.0 is available from https://github.com/gerardbm/atomic and it had syntax using italic and underline at the same time. I will remove this version. The newest version is the current repository (https://github.com/gerardbm/vim-atomic). In this version I removed the style 'italic,underline' for the following cases: SpellBad, SpellCap, SpellLocal, SpellRare; and I removed the style 'italic' for these cases: cssPseudoClass, cssPseudoClassId, cssPseudoClassFn, cssPseudoClassLang and VendorPrefix. I only kept the style 'italic' in markdownItalic. If you installed first the version 3.0 manually or using the script Probably, it's what happened here. BTW, I like the issue because it will help others, and it remembered me I have to remove the old version. If it's not your case, it would be nice to know more info about your terminal, your font used, your vim and neovim versions and the result of You can also check italics and underline in your terminal with this command: The reason I removed the style 'italic,underline' is because some terminals don't support it, it's difficult to make it work into tmux, and the goal of it was to make a colorscheme with the same look and usability for all terminal emulators. So at the end I decided to implement italics only when it's a WYSIWYG format as in markdown files. I tried both versions (3.0 and 3.1) and they are working on vim and neovim, so I can't reproduce the issue using the terminals URxvt, XTerm and gnome-terminal, using vim 8.0.707 and neovim through AppImage 2.2 and 3.1. It fails when the variable Tell me if this info helped you. Regards! :) |
I'm not sure what is happening because it depends on too many factors (variable
I will investigate more to clarify the factors affecting this issue. By the way, there's an issue related to Vim and the use of the prefixes Thanks for your information. Any help is welcome! |
Thanks 😄 |
It's probably a Neovim issue. This is what happens with atomic and solarized (both cases). Using gnome-terminal (xterm-256color), terminator (xterm-256color), xfce4-terminal (xterm-256color):
Using rxvt-unicode-256color terminal (screen-256color), xterm (screen-256color), lxterminal (xterm):
What I don't understand is why I'm getting identical results for both color schemes. I only get different results changing the terminal or the There's a pattern: it works when @Karmenzind, could you try setting this By the other hand, in Vim is possible to set termcap codes (for example to fix emphasis support), however Neovim handles it automatically, it's term-dependent (according to In Vim, the output should be '3m' and '23m', if not, this fixes the problem: let &t_ZH="\e[3m"
let &t_ZR="\e[23m" In Neovim, the output is the error «E846: Key code not set». It should work automatically, and these settings were removed. This info won't fix the issue, but it's useful. It will help others as well. I have another question: why do you use PS. I didn't know about Alacritty terminal. I will give it a try when I have more time. It's interesting! Edit: I asked to Alacritty devs. This is the line of code with the default Check it because using |
sorry, a little busy here...
hmmm... It's a typo. The real number of my |
Sorry for the late.
It's weird. I'll try with alacritty later. BTW, |
I really love this colorscheme 😄 Thanks for your work.
Recently I started using neovim then I found italic and underline didn't show as it does in regular Vim.
But other colorsheme, like Solarized, worked well in both Vim and Neovim.
Close it if there is no need to solve it.
The text was updated successfully, but these errors were encountered: