-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistencies between photolysis species listed in species_database.yml
and FJX_j2j.dat
for fullchem mechanism
#2456
Comments
Also CF3I is listed in |
Some of the species not in |
It looks like there are other oddities as well, such as |
You can ignore my first comment above since I was confused about what |
The photolyzing species are defined in The |
I'm not sure there is. I think I may have added species to the |
Just to be clear on terminology, which of the two below statements is true:
Intuitively I would think the first is true, with J-values either coming from its reaction specifically or mapped from J-values for a different reaction. |
@lizziel: Good point. I would say that in general Statement 1 is true. Not all species would have to be have a J-rate computed by FAST-JX or Cloud-J, as you could have a species with a constant J-value that is just specified in the KPP equation file. In the current GEOS-Chem fullchem mechanism, all photo reactions have rates generated by Cloud-J (they are stored in the PHOTOL array and passed to KPP that way). |
@lizziel: If you count up all the rxns with I will do a cross-check of the |
Hi @lizziel and @yantosca. I am worried something has gone wrong in how I did the pull request. I updated the species_database.yml and geoschem_config.fullchem.yml in my pull request. Both have ACR listed and species_database has ACR as photolyzing. It is also a photolysis rx in fullchem.eqn, and it is just given the same rate as MACR (PHOTOL(66) in the attached files). |
Hi @ktravis213. I think I have it all sorted out in PR #2457. Am running some tests before I declare it ready for review. |
We can now close out this issue as PR #2457 has been merged into the GEOS-Chem 14.5.0 development stream. |
Your name
Bob Yantosca
Your affiliation
Harvard + GCST
What happened? What did you expect to happen?
While benchmarking the recent chemistry updates added in PR #2318 and PR #2371, I noticed that there were several mismatches between species that were declared with
Is_Photolyis: true
in thespecies_database.yml
file and theFJX_j2j.dat
file (which tells Cloud-J which species are photolyzing).Configuration files:
What are the steps to reproduce the bug?
I wrote the following Python script to compare species that were defined with
Is_Photolysis: true
inspecies_database.yml
vs. theFJX_j2j.dat
file:Which gives this output:
we can ignore the Hg* and O3* species, as these are for specialty simulations. But as you can see, there are several photolyzed species in
FJX_j2j.dat
that are not tagged withIs_Photolysis: true
in thespecies_database.yml
file. Thus, the J-value diagnostics for these species will not be archived.Also, note there is a halogen species
H12O2
(which I think is a typo forH1202
aka CF2Br2 "dibromodilfluoromethane" that is not currently in the fullchem mechanism.I can edit the species database file accordingly to remove the
Is_Photolysis: True
tag from the species that are not inFJX_j2j.dat
. But what should we do aboutH12O2
?Tagging @msulprizio @lizziel @ktravis213 @kelvinhb
Please attach any relevant configuration and log files.
No response
What GEOS-Chem version were you using?
14.5.0 in prep
What environment were you running GEOS-Chem on?
Local cluster
What compiler and version were you using?
gcc 10.2.0
Will you be addressing this bug yourself?
Yes, but I will need some help
In what configuration were you running GEOS-Chem?
GCClassic
What simulation were you running?
Full chemistry
As what resolution were you running GEOS-Chem?
4x5
What meterology fields did you use?
MERRA-2
Additional information
No response
The text was updated successfully, but these errors were encountered: