-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new providers in session #12
Comments
What would be the goal of this? If someone wants to define and use a custom TileProvider, they can also do |
We want to have a method that expands the existing Bunch from a custom JSON (#14). But if you don't have a JSON you may want to expand it in a different way and keep all providers within a single Bunch instead of having each as an object. It is not aimed so much at the addition of a single TileProvider but more of them. And we may use this under the hood in #14 so no reason not to expose it. |
But also for #14, can you explain why you want to add it to the existing bunch of the package instead of creating a new bunch? |
Let's assume that ipyleaflet, geopandas_view or any other package adds an interactive list of available basemaps, similar to what folium has (http://leaflet-extras.github.io/leaflet-providers/preview/), you want to ingest a single bunch from xyzservices. If you also want to add some custom basemaps (like custom CartoDB tiles) you want to append them to the existing bunch. |
Develop a method within a
Bunch
that can append newTileProvider
instances to a loaded set of providers. It should work something like:The text was updated successfully, but these errors were encountered: