Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running with same sample and case name crashes in RENAME_FILES #164

Open
Jakob37 opened this issue Oct 4, 2024 · 2 comments
Open

Running with same sample and case name crashes in RENAME_FILES #164

Jakob37 opened this issue Oct 4, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Jakob37
Copy link
Contributor

Jakob37 commented Oct 4, 2024

Description of the bug

I am running a single sample, and ended up assigning the same ID for both "sample" and "case" columns in the input samplesheet.

This crashes in a step where Tomte attempts to softlink the same name to itself.

Not 100% the identical case/sample is the reason, but would suspect so. Will try changing the case and rerun.

I am working on a branch from #147, so if later fixed in dev, this is a non-issue.

Command used and terminal output

ERROR ~ Error executing process > 'GENOMICMEDICINESWEDEN_TOMTE:TOMTE:ALLELE_SPECIFIC_CALLING:RENAME_FILES (<ID>)'

Caused by:
  Process `GENOMICMEDICINESWEDEN_TOMTE:TOMTE:ALLELE_SPECIFIC_CALLING:RENAME_FILES (<ID>)` terminated with an error exit status (1)


Command executed:

  ln -s <ID>.vcf.gz <ID>.vcf.gz

  cat <<-END_VERSIONS > versions.yml
  "GENOMICMEDICINESWEDEN_TOMTE:TOMTE:ALLELE_SPECIFIC_CALLING:RENAME_FILES":
      ln: $(echo $(ln --version 2>&1 | head -n 1 | cut -d ' ' -f4))
  END_VERSIONS

Command exit status:
  1

Command output:
  (empty)

Command error:
  ln: <ID>.vcf.gz: File exists

Work dir:
  /<work>/10/05e1e81edf6d6dc5f5f06df112c207

Tip: you can replicate the issue by changing to the process work dir and entering the command `bash .command.run`

 -- Check '.nextflow.log' file for details
ERROR ~ Pipeline failed. Please refer to troubleshooting docs: https://nf-co.re/docs/usage/troubleshooting

 -- Check '.nextflow.log' file for details


### Relevant files

_No response_

### System information

_No response_
@Jakob37 Jakob37 added the bug Something isn't working label Oct 4, 2024
@Lucpen
Copy link
Collaborator

Lucpen commented Oct 4, 2024

Hi Jakob,
I don't think it should be allowed to have the same sample and case ID as tracking output files is more simple, if you would add another sample you could end up with a case called as one of the sample with another sample in side or you could end up with a trio named after the patient.

Perhaps we could add a check at the very start of the pipeline? That way it would complain right away and it just won't run. Does that sound reasonable?

@Jakob37
Copy link
Contributor Author

Jakob37 commented Oct 4, 2024

Yes, that makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants