Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skip for SV calling #544

Merged
merged 10 commits into from
Jan 24, 2025
Merged

Add skip for SV calling #544

merged 10 commits into from
Jan 24, 2025

Conversation

padraicc
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@padraicc padraicc requested a review from a team as a code owner January 24, 2025 11:02
@fellen31
Copy link
Collaborator

Nice! There's a new edge release of Nextflow that's not compatible with the nf-core template. I changed the CI tests to use the latest stable version of Nextflow instead in #545. Try to see if all pass after that.

fellen31
fellen31 approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@fellen31 fellen31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution!

@padraicc padraicc merged commit c853f32 into genomic-medicine-sweden:dev Jan 24, 2025
23 checks passed
@fellen31 fellen31 mentioned this pull request Jan 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fellen31 fellen31 fellen31 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Nallo
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@padraicc @fellen31