-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DDC issues #8
Comments
I created an issue at jskos-tools (gbv/jskos-tools#28) but think the best workaround to notations starting with T is to remove the T on import, so s/:\d+$//; # remove colon suffix
if ($_ =~ /^T(\d[ABC]?)--/) {
$table = $1;
$_ =~ s/T\d[ABC]?--//g; # remove all T...
$_ = $table . "--" . $_; # add back removed table number
} This fits to existing notation pattern used in existing DDC data in RDF. |
To clarify classes with colon suffixes
|
Could you clarify this further? I still don't understand this part. Referring to WebDewey Deutsch, they have different labels:
In the decomposition of |
Apart from removing the colon suffix (see my previous comment), this is looking good. I could try to adjust this to JavaScript and add it to coli-ana first (and if it works as expected, we could add it to jskos-tools). |
The workaround is implemented but
|
Yeah, I didn't add URIs there in order to save space in the database, but we can add the URIs during conversion. |
Closed in favor of more specific #13. |
There are some issues with our version of DDC German (in https://coli-conc.gbv.de/api/) and our tools that need to be addressed before coli-ana can work properly:
:
in their notation, for exampleT1--0901-T1--0905:07
).uriFromNotation
method currently does not work correctly with the tables. For example,uriFromNotation("T1--0")
returnshttp://dewey.info/class/T1--0/e23/
even though it should behttp://dewey.info/class/1--0/e23/
.The text was updated successfully, but these errors were encountered: