-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support TPP1 mapper #846
Comments
Additionally, @aaaaaa123456789's spec mentions that the test ROM needs to be compiled with TPP's fork of RGBDS. What features are required? |
The only special feature that thing supports is setting the control values and the custom fields in the header, and some minor changes to RGBASM and RGBLINK to increase the bank limit. |
Don't they support 32-bit bank IDs? |
No, the max valid bank for TPP1 is $FFFF for ROM and $FF for SRAM. |
I'm talking about RGBASM and RGBLINK, which use |
I don't know how RGBDS does bank types now, but that version used the same value for bank type and bank number (using different ranges to tell the bank types apart), so it had to support $10000 (ROM) + 2 (VRAM) + $100 (SRAM) + 8 (WRAM) + 1 (OAM) + 1 (HRAM) = $1010c banks, requiring more than 16 bits. |
SameBoy 0.14.3 and BGB 1.5.9 added support for the TPP1 mapper. It may be useful to add support for it in RGBDS, which should amount of changes in RGBFIX.
(RGBASM and RGBLINK already support 31-bit bank IDs, way over TPP1's 16-bit; TPP1 keeps the same ROM layout as the MBCs, making this independent of #524; and any constants for the MR* regs would be handled in a hardware.inc fork or "add-on")
The changes to be made to RGBFIX:
-m TPP1_1.0
(or similar syntax, to indicate the spec's version); possibly with+BATTERY
,+RUMBLE
etc. flags to specify what to write to $0153The text was updated successfully, but these errors were encountered: