Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with Element::GetAttribute()/HasAttribute()/etc #54

Closed
osrf-migration opened this issue Mar 22, 2014 · 1 comment
Closed

Problem with Element::GetAttribute()/HasAttribute()/etc #54

osrf-migration opened this issue Mar 22, 2014 · 1 comment
Labels
1.5 bug Something isn't working minor

Comments

@osrf-migration
Copy link

Original report (archived issue) by Jonathan Bohren (Bitbucket: jbohren).


If an sdf plugin tag has custom child tags, are those tags allowed to have attributes?

I tried loading some custom tags in a plugin, but the tag attributes don't seem to be loaded. If I put the same information in child tags it does work.

For example, SDF Element::GetAttributeCount() returns 0 for the following child tag of a plugin tag:

<custom foo="somevalue"/>
@osrf-migration osrf-migration added minor bug Something isn't working 1.5 labels Apr 11, 2020
scpeters added a commit that referenced this issue Apr 29, 2024
Update test to confirm that #54 is fixed.

Signed-off-by: Steve Peters <[email protected]>
@scpeters
Copy link
Member

custom attributes are now supported in custom elements according to the following proposal

I have confirmed this by updating an existing test in #1406

scpeters added a commit that referenced this issue Jun 19, 2024
Update test to confirm that #54 is fixed.

Signed-off-by: Steve Peters <[email protected]>
aagrawal05 pushed a commit to aagrawal05/sdformat that referenced this issue Aug 16, 2024
Update test to confirm that gazebosim#54 is fixed.

Signed-off-by: Steve Peters <[email protected]>
aagrawal05 pushed a commit to aagrawal05/sdformat that referenced this issue Aug 16, 2024
Update test to confirm that gazebosim#54 is fixed.

Signed-off-by: Steve Peters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.5 bug Something isn't working minor
Projects
None yet
Development

No branches or pull requests

2 participants