Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update navsat proto to include covariance #489

Open
wants to merge 1 commit into
base: gz-msgs11
Choose a base branch
from

Conversation

EmmanuelMess
Copy link

@EmmanuelMess EmmanuelMess commented Mar 6, 2025

🦟 Bug fix

Fixes #488

Summary

This PR adds parity with https://github.com/ros2/common_interfaces/blob/master/sensor_msgs/msg/NavSatFix.msg message.
For completeness it also adds the velocity DOP.

Disclamer: I have no idea how this actually integrates with the rest of gazebo, and I couldn't find much info, so I would thank you if you tell me where I would need to add code to make it work with the gz ros2 bridge.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@EmmanuelMess EmmanuelMess requested a review from caguero as a code owner March 6, 2025 01:34
@github-actions github-actions bot added 🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty labels Mar 6, 2025
@EmmanuelMess EmmanuelMess force-pushed the emmanuelmess/fix/navsat_msg_dop branch from db646e1 to a1f59d9 Compare March 6, 2025 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty
Projects
Status: Inbox
Development

Successfully merging this pull request may close these issues.

Add covariance (or dop) for navsat proto
1 participant