gazebo11 homebrew CI builds failing with cmake 3.22.0

[scpeters]

Since the latest version of tbb in homebrew-core has removed APIs that gazebo11 uses (gazebosim/gazebo-classic#2867), we have added an older version of tbb@2020_u3 to our homebrew-simulation tap (osrf/homebrew-simulation#1483) along with special handling for environment variables in CI scripts since this formula is not installed to /usr/local (#465 and #466). The gazebo-ci-gazebo11-homebrew-amd64 was passing as recently as November 16:

• https://build.osrfoundation.org/job/gazebo-ci-gazebo11-homebrew-amd64/109/

The job is now failing with error messages indicating that it is including the header files from the main tbb formula installed to /usr/local.

• https://build.osrfoundation.org/job/gazebo-ci-gazebo11-homebrew-amd64/110/

In file included from /Users/jenkins/workspace/gazebo-ci-gazebo11-homebrew-amd64/gazebo/gazebo/transport/ConnectionManager.cc:22:
In file included from /Users/jenkins/workspace/gazebo-ci-gazebo11-homebrew-amd64/gazebo/gazebo/transport/TopicManager.hh:35:
In file included from /Users/jenkins/workspace/gazebo-ci-gazebo11-homebrew-amd64/gazebo/gazebo/transport/SubscriptionTransport.hh:24:
/Users/jenkins/workspace/gazebo-ci-gazebo11-homebrew-amd64/gazebo/gazebo/transport/Connection.hh:57:65: error: expected class name
    class GZ_TRANSPORT_VISIBLE ConnectionReadTask : public tbb::task
                                                                ^
/Users/jenkins/workspace/gazebo-ci-gazebo11-homebrew-amd64/gazebo/gazebo/transport/Connection.hh:73:20: error: no type named 'task' in namespace 'tbb'
      public: tbb::task *execute()
              ~~~~~^

I believe the failure has occurred since cmake 3.22.0 was merged in Homebrew/homebrew-core#89638 based on tests on my local machine with cmake 3.21.0 and 3.22.0.

It's hard to avoid installing the main tbb formula since ogre1.9 uses the one in homebrew-core. Some possible solutions:

• Try to fix the underlying issue in gazebo11 (TBB task is deprecated and removed in oneTBB 2021.01 gazebosim/gazebo-classic#2867) with ifdefs based on the TBB version and then stop using our tbb@2020_u3 fork
• Try rebuilding the ogre1.9 bottle, against our fork of tbb@2020_u3
• We can try more magic with environment variables to try to prevent a -I/usr/local/include compiler flag (brittle solution)

[scpeters]

As a workaround, I've added a [email protected] formula to our tap in osrf/homebrew-simulation#1696 that we can use for gazebo CI

[scpeters]

using cmake 3.21.4 fixes it for now