From deb6db65cc2364ea8945ae4d23eda69e5a91f866 Mon Sep 17 00:00:00 2001 From: yihong Date: Mon, 18 Mar 2024 18:04:07 +0800 Subject: [PATCH 1/3] fix: delete sim_main in `__init__` all Caused it never use since sim_main had been deteled. also add test for `from viztracer import *` in test_cmdline.py Signed-off-by: yihong0618 --- src/viztracer/__init__.py | 1 - tests/test_cmdline.py | 3 +++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/viztracer/__init__.py b/src/viztracer/__init__.py index 853f5e32..c0f68b82 100644 --- a/src/viztracer/__init__.py +++ b/src/viztracer/__init__.py @@ -16,7 +16,6 @@ __all__ = [ "__version__", "main", - "sim_main", "viewer_main", "VizTracer", "ignore_function", diff --git a/tests/test_cmdline.py b/tests/test_cmdline.py index 6118982c..a287a7a8 100644 --- a/tests/test_cmdline.py +++ b/tests/test_cmdline.py @@ -379,6 +379,9 @@ def test_pid_suffix_and_output(self): def test_module(self): self.template(["viztracer", "-m", "numbers"]) + def test_import_star(self): + self.template(["python", "-c", "from viztracer import *"], expected_output_file=None) + def test_log_gc(self): self.template(["viztracer", "--log_gc", "cmdline_test.py"], script=file_gc) From 3c87b6d9bcd6450f121c128bd8e61d7cd5ab5a18 Mon Sep 17 00:00:00 2001 From: Tian Gao Date: Mon, 18 Mar 2024 21:31:55 -0700 Subject: [PATCH 2/3] Do not create script --- tests/test_cmdline.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_cmdline.py b/tests/test_cmdline.py index a287a7a8..4f75e880 100644 --- a/tests/test_cmdline.py +++ b/tests/test_cmdline.py @@ -380,7 +380,7 @@ def test_module(self): self.template(["viztracer", "-m", "numbers"]) def test_import_star(self): - self.template(["python", "-c", "from viztracer import *"], expected_output_file=None) + self.template(["python", "-c", "from viztracer import *"], script=None, expected_output_file=None) def test_log_gc(self): self.template(["viztracer", "--log_gc", "cmdline_test.py"], script=file_gc) From 1432620e914bb12b5e036ec991985f1117f2deb5 Mon Sep 17 00:00:00 2001 From: Tian Gao Date: Mon, 18 Mar 2024 22:10:14 -0700 Subject: [PATCH 3/3] -c does not work with coverage --- tests/test_cmdline.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/test_cmdline.py b/tests/test_cmdline.py index 4f75e880..40bd5a64 100644 --- a/tests/test_cmdline.py +++ b/tests/test_cmdline.py @@ -380,7 +380,8 @@ def test_module(self): self.template(["viztracer", "-m", "numbers"]) def test_import_star(self): - self.template(["python", "-c", "from viztracer import *"], script=None, expected_output_file=None) + script = "from viztracer import *" + self.template(["python", "cmdline_test.py"], script=script, expected_output_file=None) def test_log_gc(self): self.template(["viztracer", "--log_gc", "cmdline_test.py"], script=file_gc)