Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report Builder Bug #412

Closed
yilin412 opened this issue Mar 15, 2024 · 1 comment · Fixed by #419
Closed

Report Builder Bug #412

yilin412 opened this issue Mar 15, 2024 · 1 comment · Fixed by #419

Comments

@yilin412
Copy link

report_builder.py line 77: except json.JSONDecodeError

json is not imported when user has orjson installed.

Btw, this bug was found when using multiprocessing.Pool on Windows. I guess the exception here is what you called "there’s no way to gracefully catch the exit of the process."
@gaogaotiantian
Copy link
Owner

Ah, interesting. Yes, there's nothing we can do to make multiprocessing.Pool work with viztracer. The bug however, is real, we should not catch json.JSONDecodeError when we are using orjson.

@gaogaotiantian gaogaotiantian linked a pull request Mar 27, 2024 that will close this issue
Fix the non-exist json module when orjson is used #419
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the non-exist json module when orjson is used gaogaotiantian/viztracer
2 participants
@gaogaotiantian @yilin412