Inconsistent naming of sim_telarray

[GernotMaier]

There is a bit of an inconsistency in the name of sim_telarray in the code:

• model_parameters calls it simtel: self._simulation_config_parameters = {"corsika": {}, "simtel": {}}
• db_handler in generally sim_telarray (e.g., in collection="configuration_sim_telarray",
• the schema file list the software packages as sim_telarray

Would be easier to have one single name (e.g., we could remove the list of hardwired config parameters).

(this is a minor issue)

[orelgueta]

I think KB would vote for changing to sim_telarray everywhere.

[GernotMaier]

I know and I can understand (I do not like it either when others are changing the name of 'my' software).

There is a small and a larger possibility to change:

• make sure that the software is always called sim_telarray in all configurations, schemas, dictionary (mostly the issue; this would also simplify the code)
• by very consistent and rename also all modules in simtools.simtel

[orelgueta]

I would vote to do it everywhere. I can even try and volunteer to do it if I have some "dead time" in the next few weeks.

[GernotMaier]

I think you should use your dead time for something better.

Anyway, this would be my list to approach this issue:

• add a function to names.py to read the list of available simulation software from src/simtools/schemas/model_parameter_and_data_schema.metaschema.yml (instead of the hardwired list in model_parameters - not sure if there are more of them); note that after merging of Replace model parameter default schema versions by value read from model_parameter.metaschema.yml #1332 , this file will be accessible through simtools.constants.MODEL_PARAMETER_DESCRIPTION_METASCHEMA.
• generalize if possible the functions using those lists. Allow for additions (see e.g., testeff in Add functionality to select model parameters for certain simulation software types. #1340)
• boring renaming of the modules.

[orelgueta]

OK, sounds like a good plan!