You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For some reason, in v5, maxAttempts was renamed to maxRetries, but the behaviour wasn't changed, so maxRetries still really means maxTries. If you could set it to 0 (which you can't) it wouldn't try the query at all.
Note that the number of attempts is not the same as the number of tries. One try may contain three attempts if it has to try three different ports.
The later part can be addressed by using the givenPortOnly option, which I would highly recommend if you know the correct port or implemented you own "ports to try" logic outside of gamedig.
I think slightly modifying the log output to clarify what it has done might save any misunderstanding. Something like Error: Failed all 1 attempts with 2 ports tried might be a good idea.
dgibbs64
changed the title
bug: maxRetries will always try at lease twice
bug: maxRetries will always try at least twice
Sep 23, 2024
Describe the bug
When I set maxRetries to 1 or 0 gamedig will still retry at least twice sometimes 3 times.
Steps To Reproduce
set maxRetries to 1 or 0 and see at least 2 failed attempts
Expected behavior
gamedig should try only once
Error: Failed all 3 attempts
The text was updated successfully, but these errors were encountered: