Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BWA-MEM2 indexing tool #6823

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Mar 9, 2025

Builds on #6558

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

@bgruening
Copy link
Member

Can we somehow reuse the data managers? It seems redundant to create a new index tool for all our reference consuming tools.

@mvdbeek
Copy link
Member Author

mvdbeek commented Mar 9, 2025

I don't see how. You'd have to look at every data manager, exclude the parameters that are unsafe and then allowlist user execution. Picking up a directory from extra_files_path is way simpler.

@bgruening
Copy link
Member

Somehow, I thought the plan was to enforce data-bundles for non-admin users and consume those data-bundles by tools. Did I mixed that up?

@mvdbeek
Copy link
Member Author

mvdbeek commented Mar 10, 2025

That was the plan, but I don't think it's working out. It starts with data managers being pretty complicated to write, then you got a single extension .data_manager_json for all of the different table types, data managers can create more than one entry, the dbkey displayname etc values don't really make sense in the context of history items.

I think it would make more sense to go the other way around and have a data manager that knows how to consume datatypes like bwa_mem2_index and turns it into a loc file entry by adding the required metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants