Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI support to prepend/append #63

Open
weitzman opened this issue May 5, 2014 · 5 comments
Open

Add CLI support to prepend/append #63

weitzman opened this issue May 5, 2014 · 5 comments

Comments

@weitzman
Copy link

weitzman commented May 5, 2014

The prepend and append includes specifically do not support CLI requests. Is that a design choice or merely "noone has written it"? I'm interested in contributing this if there is interest. Any guidelines/tips would be appreciated.

@weitzman weitzman changed the title Add CLi support to prepend/append Add CLI support to prepend/append May 5, 2014
@gajus
Copy link
Owner

gajus commented May 5, 2014

I suppose the reason why CLI was chosen to be excluded is because xhprof interface relies on SERVER_NAME and similar environment variables. This would require either a separate interface for the CLI script execution index or default values to something like "CLI-ENV" and use file path instead of server name.

@weitzman
Copy link
Author

yes, i think we can find good analogies for those env variables when
running cli requests. implode(' ', $_SERVER["argv"]) is a good value for
REQUEST_URI.

@camronlevanger
Copy link

I think CLI support by default would be a great addition. I might need to get it working for a project, if I do I will open a PR.

@staabm
Copy link
Contributor

staabm commented Jul 2, 2014

I would definitly accept a PR against https://github.com/staabm/xhprof.io for CLI support.

@damienalexandre
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants