Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The cookie banner seems to be broken a bit #54

Closed
suda opened this issue Jul 14, 2024 · 2 comments
Closed

The cookie banner seems to be broken a bit #54

suda opened this issue Jul 14, 2024 · 2 comments
Assignees
@suda

Comments

@suda
Copy link
Contributor

suda commented Jul 14, 2024

  1. The colors and size are off compared to the design:
Screenshot 2024-07-14 at 11 03 43
  1. It's necessary to click accept/reject cookies twice to dismiss the dialog
@emendelski emendelski assigned suda and unassigned emendelski Jul 16, 2024
@emendelski
Copy link
Contributor

emendelski commented Jul 16, 2024 •
edited
Loading

Fixes issue 1 in this commit a98b923

About double click necessary it's probably partially an issue with the plugin. There's no event for accepting/rejection for me to check if the modal should be visible. Someone else created similar issue in their repo: beyonk-group/gdpr-cookie-consent-banner#67

@suda
Copy link
Contributor Author

suda commented Jul 16, 2024

Awesome. I guess problem 2 is not that bad, we can wait until they fix it upstream 👍

@suda suda closed this as completed Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@suda suda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@suda @emendelski