From c9007c3bfa6a29f2f99574ede8dfc616d890abb1 Mon Sep 17 00:00:00 2001 From: Julian Bissekkou <36447137+JulianBissekkou@users.noreply.github.com> Date: Thu, 22 Aug 2024 16:54:32 +0200 Subject: [PATCH] fix lint warnings and move dart and flutter sdk up (#80) --- .../arcgis_map_sdk_platform_interface.dart | 2 +- .../lib/location_indicator_example_page.dart | 5 ++- example/lib/main.dart | 2 +- example/pubspec.lock | 32 +++++++++---------- 4 files changed, 20 insertions(+), 21 deletions(-) diff --git a/arcgis_map_sdk_platform_interface/lib/src/arcgis_map_sdk_platform_interface.dart b/arcgis_map_sdk_platform_interface/lib/src/arcgis_map_sdk_platform_interface.dart index fe78fac6..1894d114 100644 --- a/arcgis_map_sdk_platform_interface/lib/src/arcgis_map_sdk_platform_interface.dart +++ b/arcgis_map_sdk_platform_interface/lib/src/arcgis_map_sdk_platform_interface.dart @@ -22,7 +22,7 @@ class ArcgisMapPlatform extends PlatformInterface { throw UnimplementedError('init() has not been implemented.'); } - Future exportImage(int mapId) { + Future exportImage(int mapId) { throw UnimplementedError('exportImage() has not been implemented.'); } diff --git a/example/lib/location_indicator_example_page.dart b/example/lib/location_indicator_example_page.dart index 523f7122..27a056c9 100644 --- a/example/lib/location_indicator_example_page.dart +++ b/example/lib/location_indicator_example_page.dart @@ -241,9 +241,8 @@ class _LocationIndicatorExamplePageState _activeAutoPanMode = newSetAutoPanMode; _controller?.locationDisplay.setAutoPanMode(newSetAutoPanMode); } - if (newSetWanderExtentFactor != null && - _activeAutoPanMode == AutoPanMode.recenter) { - _wanderExtentFactor = newSetWanderExtentFactor!; + if (_activeAutoPanMode == AutoPanMode.recenter) { + _wanderExtentFactor = newSetWanderExtentFactor; _controller?.locationDisplay.setWanderExtentFactor(_wanderExtentFactor); } } diff --git a/example/lib/main.dart b/example/lib/main.dart index 51f5e92b..1a482176 100644 --- a/example/lib/main.dart +++ b/example/lib/main.dart @@ -103,7 +103,7 @@ class _ExampleMapState extends State { // TODO: Remove when mobile implementation is complete if (kIsWeb) { _controller?.onClickListener().listen((Attributes? attributes) { - if (attributes == null) return; + if (attributes == null || !mounted) return; final snackBar = SnackBar( content: Text('Attributes Id after on Click: ${attributes.data['name']}'), diff --git a/example/pubspec.lock b/example/pubspec.lock index 5099df71..ad000151 100644 --- a/example/pubspec.lock +++ b/example/pubspec.lock @@ -198,26 +198,26 @@ packages: dependency: transitive description: name: leak_tracker - sha256: "78eb209deea09858f5269f5a5b02be4049535f568c07b275096836f01ea323fa" + sha256: "3f87a60e8c63aecc975dda1ceedbc8f24de75f09e4856ea27daf8958f2f0ce05" url: "https://pub.dev" source: hosted - version: "10.0.0" + version: "10.0.5" leak_tracker_flutter_testing: dependency: transitive description: name: leak_tracker_flutter_testing - sha256: b46c5e37c19120a8a01918cfaf293547f47269f7cb4b0058f21531c2465d6ef0 + sha256: "932549fb305594d82d7183ecd9fa93463e9914e1b67cacc34bc40906594a1806" url: "https://pub.dev" source: hosted - version: "2.0.1" + version: "3.0.5" leak_tracker_testing: dependency: transitive description: name: leak_tracker_testing - sha256: a597f72a664dbd293f3bfc51f9ba69816f84dcd403cdac7066cb3f6003f3ab47 + sha256: "6ba465d5d76e67ddf503e1161d1f4a6bc42306f9d66ca1e8f079a47290fb06d3" url: "https://pub.dev" source: hosted - version: "2.0.1" + version: "3.0.1" lint: dependency: "direct dev" description: @@ -238,18 +238,18 @@ packages: dependency: transitive description: name: material_color_utilities - sha256: "0e0a020085b65b6083975e499759762399b4475f766c21668c4ecca34ea74e5a" + sha256: f7142bb1154231d7ea5f96bc7bde4bda2a0945d2806bb11670e30b850d56bdec url: "https://pub.dev" source: hosted - version: "0.8.0" + version: "0.11.1" meta: dependency: transitive description: name: meta - sha256: d584fa6707a52763a52446f02cc621b077888fb63b93bbcb1143a7be5a0c0c04 + sha256: bdb68674043280c3428e9ec998512fb681678676b3c54e773629ffe74419f8c7 url: "https://pub.dev" source: hosted - version: "1.11.0" + version: "1.15.0" path: dependency: transitive description: @@ -323,10 +323,10 @@ packages: dependency: transitive description: name: test_api - sha256: "5c2f730018264d276c20e4f1503fd1308dfbbae39ec8ee63c5236311ac06954b" + sha256: "5b8a98dafc4d5c4c9c72d8b31ab2b23fc13422348d2997120294d3bac86b4ddb" url: "https://pub.dev" source: hosted - version: "0.6.1" + version: "0.7.2" typed_data: dependency: transitive description: @@ -355,10 +355,10 @@ packages: dependency: transitive description: name: vm_service - sha256: b3d56ff4341b8f182b96aceb2fa20e3dcb336b9f867bc0eafc0de10f1048e957 + sha256: "5c5f338a667b4c644744b661f309fb8080bb94b18a7e91ef1dbd343bed00ed6d" url: "https://pub.dev" source: hosted - version: "13.0.0" + version: "14.2.5" sdks: - dart: ">=3.2.0-0 <4.0.0" - flutter: ">=3.10.0" + dart: ">=3.3.0 <4.0.0" + flutter: ">=3.18.0-18.0.pre.54"