Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot correctly path into filepath with "#" character #9

Open
kumavis opened this issue Apr 1, 2022 · 3 comments
Open

cannot correctly path into filepath with "#" character #9

kumavis opened this issue Apr 1, 2022 · 3 comments

Comments

@kumavis
Copy link

kumavis commented Apr 1, 2022

eg https://npmfs.com/package/es5-ext/0.10.59/array/#/clear.js

@g-harel
Copy link
Owner

g-harel commented Apr 1, 2022

Oh thanks for bringing this up. Quite a big issue for these packages!

This seems like the tip of the iceberg, I'll want to escape all characters in the URL, but it's of limited use if you can only find the URL while browsing the site. I'd like links to be able to be generated from a filepath and just work 🤔

@kumavis
Copy link
Author

kumavis commented Apr 4, 2022

fwiw this is the only package ive seen that does this and it breaks a handful of other tooling

@g-harel
Copy link
Owner

g-harel commented Apr 4, 2022

I think maybe some detection would be interesting, then I can handle those cases special. Like if the path from the url is different than intended then there must be an issue like this one and some kind of banner with the correct link would show up.

I agree it wouldn't make much sense to change all the path logic just for this small possibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants